Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Finder] Partially revert #17134 to fix a regression#18065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jakzal commentedMar 8, 2016
| Q | A |
|---|---|
| Branch | 2.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18013 |
| License | MIT |
| Doc PR | - |
jakzal commentedMar 8, 2016
I will not include a test case unless anyone thinks it's absolutely necessary or has a better idea than the test case below. It is rather fragile. It would also double test execution time for the finder component on travis. Finally, itfails on hhvm. namespaceSymfony\Component\Finder\Tests\Iterator;useSymfony\Component\Finder\Iterator\DepthRangeFilterIterator;useSymfony\Component\Finder\Iterator\RecursiveDirectoryIterator;class DepthRangeFilterIteratorTestextends RealIteratorTestCase{// ...publicfunctiontestFtp() {$inner =new \RecursiveIteratorIterator(newRecursiveDirectoryIterator('ftp://speedtest.tele2.net/', \RecursiveDirectoryIterator::SKIP_DOTS), \RecursiveIteratorIterator::SELF_FIRST);$iterator =newDepthRangeFilterIterator($inner,0,0);$files =iterator_to_array($iterator);$this->assertArrayHasKey('ftp://speedtest.tele2.net/1000GB.zip',$files);$this->assertArrayHasKey('ftp://speedtest.tele2.net/100GB.zip',$files);$this->assertArrayHasKey('ftp://speedtest.tele2.net/10GB.zip',$files);$this->assertArrayHasKey('ftp://speedtest.tele2.net/1GB.zip',$files); }} |
fabpot commentedMar 9, 2016
@jakzal I think a small comment above the code to explain the reason why we have such a code would probably help any future regressions and should be enough. |
89ed2e4 toead1824Comparejakzal commentedMar 9, 2016
Comment added. |
fabpot commentedMar 9, 2016
Thank you@jakzal. |
This PR was merged into the 2.3 branch.Discussion----------[Finder] Partially revert#17134 to fix a regression| Q | A| ------------- | ---| Branch | 2.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#18013| License | MIT| Doc PR | -Commits-------ead1824 [Finder] Partially revert#17134 to fix a regression