Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
fix lowest TwigBridge deps versions#18037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| "require-dev": { | ||
| "symfony/asset":"~2.7", | ||
| "symfony/finder":"~2.3", | ||
| "symfony/form":"~2.7.10|~2.8.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why not~2.7|~2.8 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This would allow, for example,2.7.0 and2.8.0 which would be used when running the CI job withdeps=low which would then fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Understood, thanks!
nicolas-grekas commentedMar 7, 2016
Thank you@xabbuh. |
This PR was merged into the 2.7 branch.Discussion----------fix lowest TwigBridge deps versions| Q | A| ------------- | ---| Branch | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#17568| License | MIT| Doc PR |This is necessary as#17568 was neither part of 2.7.10 nor 2.8.3.Commits-------526376f fix lowest TwigBridge deps versions
This is necessary as#17568 was neither part of 2.7.10 nor 2.8.3.