Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Process] getIncrementalOutput should work without calling getOutput#18023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
romainneutron commentedMar 5, 2016
| Q | A |
|---|---|
| Branch | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #17937 |
| License | MIT |
| /** | ||
| * @dataProvider provideVariousIncrementals | ||
| */ | ||
| publicfunctiontestIncrementalOutputDoesNotRequiresAnotherCall($stream,$method) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please useself::$phpBin instead ofphp direclty as done elsewhere to enhance compatibility of tests with more runtimes
38e4739 to4bcfbc2Compareromainneutron commentedMar 5, 2016
PR updated, comments addressed |
romainneutron commentedMar 5, 2016
Arg, it fails on windows... |
bd6aedb to260aeb2Compare| /** | ||
| * @dataProvider provideVariousIncrementals | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
typoDoesNotRequire
nicolas-grekas commentedMar 16, 2016
👍 |
xabbuh commentedMar 16, 2016
👍 |
nicolas-grekas commentedMar 17, 2016
Thank you@romainneutron. |
… getOutput (romainneutron)This PR was merged into the 2.7 branch.Discussion----------[Process] getIncrementalOutput should work without calling getOutput| Q | A| ------------- | ---| Branch | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#17937| License | MITCommits-------37d8695 [Process] getIncrementalOutput should work without calling getOutput
| * Reads pipes for the freshest output. | ||
| * | ||
| * @param $caller The name of the method that needs fresh outputs | ||
| * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
typo. Should be@throws
This PR was merged into the 2.7 branch.Discussion----------[Process] fix docblock syntax| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#18023 (comment)| License | MIT| Doc PR |Commits-------f909fca [Process] fix docblock syntax