Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Form] fix tests added by #16886#17988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.7fromHeahDude:fix-tests-choice_type
Mar 3, 2016

Conversation

@HeahDude
Copy link
Contributor

QA
Branch2.7+
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#16886
LicenseMIT
Doc PR-

@HeahDude
Copy link
ContributorAuthor

Feel free to close this one in favor of an alternative by@boite if any.

@boite
Copy link
Contributor

Thanks@HeahDude I'll look these over and make sure they agree with some recent changes to the placeholder normalizer.

@HeahDude
Copy link
ContributorAuthor

Yes I've already changed some assertions to take that into account ;)

@boite
Copy link
Contributor

👍 Good work@HeahDude.

What was your reason for removing the final three tests in the single, expanded, required section?

Status: Reviewed

@HeahDude
Copy link
ContributorAuthor

@boite Because whenChoiceType is expanded and required, it never has a placeholder.

seehttps://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php#L356

@HeahDude
Copy link
ContributorAuthor

Note to merger : only 2.x branches.

@boite
Copy link
Contributor

I suppose that if that code is unlikely to change then there's no harm in having removed the tests.

@boite
Copy link
Contributor

Branches 2.7 and 2.8 only.

@HeahDude
Copy link
ContributorAuthor

yes, this precision was in the description ;)

@webmozart
Copy link
Contributor

Thanks for this PR@HeahDude :) What about the failing tests in the PHP 7 build?

@HeahDude
Copy link
ContributorAuthor

@webmozart I know I still miss to understand.

It's like the PHP 7 build of travis does not take into account commits of#17568 and#17973.

Any lead ?

@fabpot
Copy link
Member

@HeahDude That's because the tests use the form component from v2.7.10, which does not include the two PRs you mention.

@fabpot
Copy link
Member

Thank you@HeahDude.

@fabpotfabpot merged commitbd22c86 intosymfony:2.7Mar 3, 2016
fabpot added a commit that referenced this pull requestMar 3, 2016
This PR was merged into the 2.7 branch.Discussion----------[Form] fix tests added by#16886| Q             | A| ------------- | ---| Branch        | 2.7+| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#16886| License       | MIT| Doc PR        | -Commits-------bd22c86 minor [Form] fix tests added by#16886
@HeahDude
Copy link
ContributorAuthor

Thanks@fabpot for your explanation :)

@HeahDudeHeahDude deleted the fix-tests-choice_type branchMarch 3, 2016 12:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@HeahDude@boite@webmozart@fabpot@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp