Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] fix tests added by #16886#17988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
HeahDude commentedMar 2, 2016
| Q | A |
|---|---|
| Branch | 2.7+ |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #16886 |
| License | MIT |
| Doc PR | - |
HeahDude commentedMar 2, 2016
Feel free to close this one in favor of an alternative by@boite if any. |
boite commentedMar 2, 2016
Thanks@HeahDude I'll look these over and make sure they agree with some recent changes to the placeholder normalizer. |
HeahDude commentedMar 2, 2016
Yes I've already changed some assertions to take that into account ;) |
boite commentedMar 2, 2016
👍 Good work@HeahDude. What was your reason for removing the final three tests in the single, expanded, required section? Status: Reviewed |
HeahDude commentedMar 2, 2016
@boite Because when |
HeahDude commentedMar 2, 2016
Note to merger : only 2.x branches. |
boite commentedMar 2, 2016
I suppose that if that code is unlikely to change then there's no harm in having removed the tests. |
boite commentedMar 2, 2016
Branches 2.7 and 2.8 only. |
HeahDude commentedMar 2, 2016
yes, this precision was in the description ;) |
webmozart commentedMar 3, 2016
Thanks for this PR@HeahDude :) What about the failing tests in the PHP 7 build? |
HeahDude commentedMar 3, 2016
@webmozart I know I still miss to understand. It's like the PHP 7 build of travis does not take into account commits of#17568 and#17973. Any lead ? |
fabpot commentedMar 3, 2016
@HeahDude That's because the tests use the form component from v2.7.10, which does not include the two PRs you mention. |
fabpot commentedMar 3, 2016
Thank you@HeahDude. |
This PR was merged into the 2.7 branch.Discussion----------[Form] fix tests added by#16886| Q | A| ------------- | ---| Branch | 2.7+| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#16886| License | MIT| Doc PR | -Commits-------bd22c86 minor [Form] fix tests added by#16886
HeahDude commentedMar 3, 2016
Thanks@fabpot for your explanation :) |