Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Yaml] ensure dump indentation to be greather than zero#17979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| publicfunction__construct($indentation =4) | ||
| { | ||
| if ($indentation <1) { | ||
| thrownew \InvalidArgumentException('The indentation must be greater than zero.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The indentation can be a float number like 3.14? or should ensure that the indentation is a natural number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The docblock states that the argument must be an integer and we don't do scalar type checks in Symfony.
fabpot commentedMar 2, 2016
Done in the merge commit. Thanks. |
xabbuh commentedMar 2, 2016
Thanks@fabpot! |
This completes#17978.