Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[2.3][WebProfilerBundle] fix debug toolbar rendering by removing inadvertently added links#17976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
craue commentedMar 1, 2016
Do you want me to create a separate PR for 2.8 as well? |
Member
stof commentedMar 1, 2016
👍 for this @craue depends whether the patch can apply cleanly or no. |
Member
fabpot commentedMar 1, 2016
Thank you@craue. |
fabpot added a commit that referenced this pull requestMar 1, 2016
…moving inadvertently added links (craue)This PR was merged into the 2.3 branch.Discussion----------[2.3][WebProfilerBundle] fix debug toolbar rendering by removing inadvertently added links| Q | A| ------------- | ---| Branch | 2.3+| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |The debug toolbar was broken by#17527...**before****and after****explanation**If `false` is explicitly passed for `link` then `link | default(true)` would evaluate to `true`, which is not what we want. The correct expression `link is not defined or link` was suggested originally in#16653.Commits-------a0ddfc4 fix debug toolbar rendering by removing inadvertently added links
Member
fabpot commentedMar 1, 2016
I've fixed the conflict myself when merging to 2.8. Thanks. |
Merged
This was referencedMar 25, 2016
Merged
Closed
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The debug toolbar was broken by#17527...
before
and after
explanation
If
falseis explicitly passed forlinkthenlink | default(true)would evaluate totrue, which is not what we want. The correct expressionlink is not defined or linkwas suggested originally in#16653.