NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[From] minor fix tests added by #17798 for bootstrap theme#17973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:2.7fromHeahDude:fix-tests-bootstrap

Mar 1, 2016

Merged

[From] minor fix tests added by #17798 for bootstrap theme#17973

fabpot merged 1 commit intosymfony:2.7fromHeahDude:fix-tests-bootstrap

Mar 1, 2016

Conversation

Copy link

Contributor

HeahDude commentedMar 1, 2016

Q	A
Branch	2.7+
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	-

[From] minor fix tests added bysymfony#17798for bootstrap theme

ee5b119

carsonbot added the Status: Needs Review label

Mar 1, 2016

Copy link

ContributorAuthor

HeahDude commentedMar 1, 2016

Tests are globally failing because of a conflict with tests added in#17798 and patch from#17600

Copy link

ContributorAuthor

HeahDude commentedMar 1, 2016

ping@symfony/mergers

Copy link

Member

javiereguiluz commentedMar 1, 2016

👍

But some tests still fail, probably because of what@xabbuh explained here:#17568 (comment)

Copy link

ContributorAuthor

HeahDude commentedMar 1, 2016

Yes, I still don't understand the reason, but it makes TwigBridge difficult to debug.

Copy link

Member

xabbuh commentedMar 1, 2016

Thedeps=low test should not fail.

Status: Needs work

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Mar 1, 2016

Copy link

ContributorAuthor

HeahDude commentedMar 1, 2016

Ok I keep investigating then.

Copy link

ContributorAuthor

HeahDude commentedMar 1, 2016

@xabbuh, It's not the first PR where I notice this, travis builds for php 5.6 and php 7 run the tests without taking into account the PR commits.

I don't see what I can do...

???

Copy link

Member

fabpot commentedMar 1, 2016

Thank you@HeahDude.

fabpot merged commitee5b119 intosymfony:2.7

Mar 1, 2016

fabpot added a commit that referenced this pull request

Mar 1, 2016

minor#17973[From] minor fix tests added by#17798for bootstrap the…

7c3e4cf

…me (HeahDude)This PR was merged into the 2.7 branch.Discussion----------[From] minor fix tests added by#17798 for bootstrap theme| Q             | A| ------------- | ---| Branch        | 2.7+| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | -Commits-------ee5b119 [From] minor fix tests added by#17798 for bootstrap theme