NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Serializer] Harden the ObjectNormalizer#17959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

dunglas wants to merge2 commits intosymfony:masterfromdunglas:srlzr_catch_typeerror

Closed

[Serializer] Harden the ObjectNormalizer#17959

dunglas wants to merge2 commits intosymfony:masterfromdunglas:srlzr_catch_typeerror

Conversation

Copy link

Member

dunglas commentedFeb 29, 2016

Q	A
Branch	master
Bug fix?	no
New feature?	yes
BC breaks?	yes
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

Transform\TypeErrors to catchable serializer exceptions.

Follows#17738 and completes#17660.

dunglas added the Serializer label

Feb 29, 2016

dunglas mentioned this pull request

Feb 29, 2016

[Serializer] Integrate the PropertyInfo Component (recursive denormalization and hardening)#17660

Merged

fabpot reviewed

Mar 1, 2016

View reviewed changes

src/Symfony/Component/Serializer/composer.json Outdated

		"symfony/yaml":"~2.8\|~3.0",
		"symfony/config":"~2.8\|~3.0",
		"symfony/property-access":"~2.8\|~3.0",
		"symfony/property-access":"~3.1",

Copy link

Member

fabpotMar 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

IIUC, this is "just" to make the test pass, right? The code change itself does not need that. So, IMO, we should keep the constraint as is and tweak the test instead.

javiereguiluz added the Enhancement label

Mar 2, 2016

Copy link

MemberAuthor

dunglas commentedMar 4, 2016

Status: needs work

carsonbot added the Status: Needs Work label

Mar 4, 2016

[Serializer] Harden the ObjectNormalizer

5d4d0a6

dunglas force-pushed thesrlzr_catch_typeerror branch fromfc84692 to5d4d0a6Compare

March 25, 2016 21:31

Copy link

MemberAuthor

dunglas commentedMar 25, 2016

Status: needs review

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Mar 25, 2016

dunglas added the Ready label

Mar 25, 2016

Copy link

Member

xabbuh commentedMar 26, 2016

You have update the minimum version required for the PropertyAccess component in therequire-dev section to be~3.1.

Status: Needs work

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Mar 26, 2016

Copy link

MemberAuthor

dunglas commentedMar 27, 2016

@xabbuh it should work with any supported PropertyAccess version as#18210 has been merged in 2.3. Maybe should I add aconflict section however.

Add a conflict section

46cc248

Copy link

MemberAuthor

dunglas commentedMar 27, 2016

Travis and AppVeyor not related.

Ping @symfony/deciders

dunglas removed the Status: Needs Work label

Mar 27, 2016

xabbuh reviewed

Mar 29, 2016

View reviewed changes

src/Symfony/Component/Serializer/composer.json

		"doctrine/cache":"~1.0"
		},
		"conflict": {
		"symfony/property-access":">=3.0,<3.0.4\|>=2.8,<2.8.4"

Copy link

Member

xabbuhMar 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Then I would rather update the constraint inrequire-devto~2.8,>=2.8.4|~3.0,>=3.0.4.

Copy link

MemberAuthor

dunglasMar 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why? The conflict line has the same effect and works in prod too.

Copy link

Member

nicolas-grekas commentedApr 17, 2016•
edited
Loading

👍 for 3.1. The composer.json update is fine to me.

nicolas-grekas added the Status: Reviewed label

Apr 17, 2016

dunglas closed this in3a165e5

Apr 18, 2016

dunglas deleted the srlzr_catch_typeerror branch

April 18, 2016 17:38

fabpot mentioned this pull request

May 13, 2016

Release v3.1.0-BETA1#18776

Merged

Labels

Enhancement Ready Serializer Status: Reviewed

		"symfony/yaml":"~2.8\|~3.0",
		"symfony/config":"~2.8\|~3.0",
		"symfony/property-access":"~2.8\|~3.0",
		"symfony/property-access":"~3.1",

Movatterモバイル変換

Uh oh!

[Serializer] Harden the ObjectNormalizer#17959

[Serializer] Harden the ObjectNormalizer#17959

Uh oh!

Conversation

dunglas commentedFeb 29, 2016

Uh oh!

fabpotMar 1, 2016

Choose a reason for hiding this comment

Uh oh!

dunglas commentedMar 4, 2016

Uh oh!

dunglas commentedMar 25, 2016

Uh oh!

xabbuh commentedMar 26, 2016

Uh oh!

dunglas commentedMar 27, 2016

Uh oh!

dunglas commentedMar 27, 2016

Uh oh!

xabbuhMar 29, 2016

Choose a reason for hiding this comment

Uh oh!

dunglasMar 29, 2016

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas commentedApr 17, 2016• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nicolas-grekas commentedApr 17, 2016•
edited
Loading