👍

I would like to rename theDUMP_MULTI_LINE_AS_BLOCK constant toDUMP_MULTI_LINE_LITERAL_BLOCK. What do you think?

The rename sounds like a good idea to me.

I renamed the constant and added a changelog entry. This is ready for the final review.

👍

We will need a doc PR for that though

Thank you@xabbuh.

Hi,
nice to see someone worked on that, thanks :)

i'm not sure if i'm doing something horrible wrong of if there is something buggy.
i'm requiring "symfony/yaml": "dev-master" with composer.

Running this simple example

<?phpinclude 'vendor/autoload.php';use Symfony\Component\Yaml\Yaml;$data = ['foo' => 'bar', 'error' => "foo\nbar"];$yaml = Yaml::dump($data, 2, 0, Yaml::DUMP_MULTI_LINE_LITERAL_BLOCK);Yaml::parse($yaml);;

throws

Fatal error: Uncaught exception 'Symfony\Component\Yaml\Exception\ParseException' with message 'Unable to parse at line 3 (near "foo").' in vendor/symfony/yaml/Parser.php on line 321

the resulting string in $yaml is:

foo: barerror: |foobar

foo and bar is not indented, why is that?

Thanks, Dirk

@schorsch3000 Sorry for that and thank you for testing the new feature. :) Would you mind opening an issue for this? It looks indeed like a bug to me.

No problem, if my wishes get fullfilled im fine doing beta-testing :)
Sure, i'll report a bug, i just wanted to know id i did something wrong :)

@schorsch3000 Oh wait, I just noticed that you passed0 as the number of spaces to indent. This number must in fact be greater than zero.

Damn, i've just reported that bug.
yes, with a sane number there everything is fine.
i've copied the call from the test-case:

$this->dumper->dump($data, 3, 0, Yaml::DUMP_MULTI_LINE_LITERAL_BLOCK));

without thinking about it.
seems this test-case is odd?

@schorsch3000 I put some explanation in#17977 (comment).

@stof I have now added all new YAML features to the list insymfony/symfony-docs#6226.