NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[2.8] [Form] fix tests added in #17798 with FQCN#17890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

HeahDude wants to merge2 commits intosymfony:2.8fromHeahDude:fix_tests-17798-2_8

Closed

[2.8] [Form] fix tests added in #17798 with FQCN#17890

HeahDude wants to merge2 commits intosymfony:2.8fromHeahDude:fix_tests-17798-2_8

Conversation

Copy link

Contributor

HeahDude commentedFeb 22, 2016

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	not yet
Fixed tickets	n/a
License	MIT
Doc PR	-

Rebase when[2.7] [Form] Fix BC break by allowing 'choice_label' option to be 'false' in ChoiceType #17798 get merged in 2.8

HeahDude added2 commits

February 22, 2016 18:12

add tests ofsymfony#17798

02d94ce

[Form] fix FQCN in tests added bysymfony#17798

7d58626

carsonbot added the Status: Needs Review label

Feb 22, 2016

HeahDude mentioned this pull request

Feb 22, 2016

[2.7] [Form] Fix BC break by allowing 'choice_label' option to be 'false' in ChoiceType#17798

Merged

4 tasks

Copy link

ContributorAuthor

HeahDude commentedFeb 26, 2016

Note for the merger :
if I don't answer to the ping for the rebase, just discard first commit when squashing before merging#17891 in 3.0.

HeahDude mentioned this pull request

Feb 26, 2016

[3.0] [Form] fix tests added by #17798 by removingchoices_as_values#17891

Closed

1 task

HeahDude changed the title~~[WIP] [2.8] [Form] fix tests added in #17798 with FQCN~~[2.8] [Form] fix tests added in #17798 with FQCN

Feb 27, 2016

fabpot added a commit that referenced this pull request

Feb 28, 2016

bug#17798[2.7] [Form] Fix BC break by allowing 'choice_label' optio…

b630ac7

…n to be 'false' in ChoiceType (HeahDude)This PR was merged into the 2.7 branch.Discussion----------[2.7] [Form] Fix BC break by allowing 'choice_label' option to be 'false' in ChoiceType| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#17773| License       | MIT| Doc PR        |symfony/symfony-docs#6282- [x] Make tests pass- [x] Adress a doc PR- [x] Replace alias by FQCN in tests for 2.8, see#17890- [x] Remove `choices_as_values` in tests for 3.0, see#17891Commits-------017e1d9 bug#17798 [Form] allow `choice_label` option to be `false`