Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WIP] [3.0] [Form] fix tests added by #17760 by removingchoices_as_values#17886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
HeahDude commentedFeb 22, 2016
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | not yet |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | - |
- Wait for[2.7] [Form] fix choice value "false" in ChoiceType #17760 being merged in 3.0
| { | ||
| $view =$this->factory->create('Symfony\Component\Form\Extension\Core\Type\ChoiceType',null,array( | ||
| 'choices' =>$this->scalarChoices, | ||
| ))->createView(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If you're merging this into 3.0, you can useChoiceType::class, not sure if that's preferable though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@iltar, I know, I even proposed to use constants in core type tests (see#17699 (comment)) as of 2.8 but this is actually to be consistent with other tests ;)
…ude)This PR was merged into the 2.7 branch.Discussion----------[2.7] [Form] fix choice value "false" in ChoiceType| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#17292,#14712,#17789| License | MIT| Doc PR | -- [x] Add tests for choices with `boolean` and `null` values, and with a placeholder- [x] Fix FQCN in 2.8 tests, see#17759- [x] Remove `choices_as_values` in 3.0 tests, see#17886Commits-------8f918e5 [Form] refactor `RadioListMapper::mapDataToForm()`3eac469 [Form] fix choice value "false" in ChoiceType
fabpot commentedFeb 26, 2016
#17760 merged |
fabpot commentedFeb 26, 2016
6d3d86d to1850da1CompareHeahDude commentedFeb 26, 2016
Should be ok. Let me know :) |
HeahDude commentedFeb 26, 2016
Not yet :( |
1850da1 toe7234d8CompareHeahDude commentedFeb 26, 2016
Ok now I'm waiting for the green lights. |
fabpot commentedFeb 26, 2016
Thank you@HeahDude. |
… `choices_as_values` (HeahDude)This PR was squashed before being merged into the 3.0 branch (closes#17886).Discussion----------[WIP] [3.0] [Form] fix tests added by#17760 by removing `choices_as_values`| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | not yet| Fixed tickets | n/a| License | MIT| Doc PR | -- [x] Wait for#17760 being merged in 3.0Commits-------03a7705 [WIP] [3.0] [Form] fix tests added by#17760 by removing