Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] add test for ArrayChoiceList handling null#17832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| { | ||
| parent::setUp(); | ||
| $this->object =new \stdClass(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this was broken because it was initialized aftergetChoices is called. so$this->object was actually null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You should maybe just put it before the call toparent::setUp() instead of removing it and keep using$this->object ingetChoices()
fabpot commentedFeb 18, 2016
Looks like this breaks the tests |
xabbuh commentedFeb 18, 2016
Using |
ffac441 to00e3819CompareTobion commentedFeb 18, 2016
Fixed |
HeahDude commentedFeb 18, 2016
👍 Status: Reviewed |
fabpot commentedFeb 18, 2016
Thank you@Tobion. |
This PR was merged into the 2.7 branch.Discussion----------[Form] add test for ArrayChoiceList handling null| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -I found this bug but then realised that it was already fixed in#17511.So this just adds a test.Commits-------00e3819 [Form] add test for ArrayChoiceList handling null
I found this bug but then realised that it was already fixed in#17511.
So this just adds a test.