Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Allow to disable the PropertyAccessor and annotations#17706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
GuilhemN commentedFeb 5, 2016
I'm waiting for feedbacks before fixing all deprecation notices. |
| ->always(function ($v) { | ||
| if (!isset($v['property_access'])) { | ||
| $v['property_access']['enabled'] =true; | ||
| @trigger_error('You must explicitly define wheter to enable "framework.property_access" or not. It will be disabled by default in 4.0',E_USER_DEPRECATED); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
not sure if that's a good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As discussed#13703, it is confusing to have some components enabled by default and some others disabled by default.
BTW this deprecation can be easily fixed in the symfony standard edition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I commented it for now as there are a lot of changes to make to fix all the deprecations in the core then ...
fabpot commentedMar 2, 2016
This one should be rebased once#17690 is merged. |
e9a2a36 tocbf2211CompareGuilhemN commentedMar 2, 2016
@fabpot I rebased this PR and commented the deprecations notices for now as it make a lot of deprecations to fix... |
GuilhemN commentedMar 26, 2016
I removed the deprecations to have something easier to review as we can still add them later. |
GuilhemN commentedJun 23, 2016
I'm closing this for now as the conflicts are too complex to fix. |
This PR was merged into the 3.2-dev branch.Discussion----------[FrameworkBundle] Remove redundant code| Q | A| ------------- | ---| Branch? | "master"| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Was part of#17706.Change the remaining ``isset($config['foo'])`` to ``$this->isConfigEnabled($config['foo'])`` to allow to use parameters to enable a feature.Commits-------a21af88 [FrameworkBundle] Remove redundant code
Includes#17690
This PR allows to disable
framework.property_accessandframework.annotationsand deprecate automatically enabling them.