Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Use canBeEnabled() instead of canBeUnset() for consistency#17690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
GuilhemN wants to merge2 commits intosymfony:masterfromGuilhemN:DOC

Conversation

@GuilhemN
Copy link
Contributor

QA
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#13703
LicenseMIT

I'm not sure if we should consider this as a bug fix or as a new feature.

@fabpot
Copy link
Member

👍

@fabpot
Copy link
Member

To keep BC, I would keep thecanBeUnset() call as well.

@GuilhemN
Copy link
ContributorAuthor

@fabpot in case someone uses the FrameworkBundle'sConfiguration class and check if keys exist ?
OtherwisecanBeEnabled threatfalse so it should not change anything to the actual configurations.

@fabpot
Copy link
Member

@Ener-Getick I know that the BC break would be small, but as it does not cost us anything to not break BC, I prefer to.

@GuilhemN
Copy link
ContributorAuthor

@fabpot well having both options wouldn't change theConfiguration output.
(allowFalse is checked afterequivalentValues, seehere).
The only thing changing would be thatArrayNode::setAllowFalse() would be called. Is this what you want ?

@fabpot
Copy link
Member

ok, fair enough, 👍

@fabpot
Copy link
Member

Thank you @Ener-Getick.

@GuilhemNGuilhemN deleted the DOC branchMarch 2, 2016 13:25
@GuilhemN
Copy link
ContributorAuthor

You're welcome :-)

And I see one solution to keepcanBeUnset but I don't know if that's not durty...

->arrayNode()    ->canBeEnabled()    ->canBeUnset()    ->threatFalseLike(false)

@fabpotfabpot mentioned this pull requestMay 13, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GuilhemN@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp