Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DependencyInjection][Routing] add files used in FileResource objects#17672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:2.3fromxabbuh:pr-17598-2.3
Feb 4, 2016

Conversation

@xabbuh
Copy link
Member

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#17598 (comment)
LicenseMIT
Doc PR

Starting with Symfony 3.1, the constructor of theFileResource class
will throw an exception when the passed file does not exist.

Starting with Symfony 3.1, the constructor of the `FileResource` classwill throw an exception when the passed file does not exist.
@xabbuhxabbuh changed the titleadd files used in FileResource objects[DependencyInjection][Routing] add files used in FileResource objectsFeb 3, 2016
@xabbuh
Copy link
MemberAuthor

ping @symfony/deciders (we need this to make the test suite pass again for all branches on Travis)

@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commit4f865c7 intosymfony:2.3Feb 4, 2016
nicolas-grekas added a commit that referenced this pull requestFeb 4, 2016
…rce objects (xabbuh)This PR was merged into the 2.3 branch.Discussion----------[DependencyInjection][Routing] add files used in FileResource objects| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#17598 (comment)| License       | MIT| Doc PR        |Starting with Symfony 3.1, the constructor of the `FileResource` classwill throw an exception when the passed file does not exist.Commits-------4f865c7 add files used in FileResource objects
@xabbuhxabbuh deleted the pr-17598-2.3 branchFebruary 4, 2016 13:57
This was referencedFeb 28, 2016
@SimonSimCity
Copy link
Contributor

Just to add this as a side-note: I also had a problem that was fixed by these lines here. My usecase was like following:

I had a class in my self-written extension, that extended a native PHP class. Thereby the parent-class hasn't had a valid includable file. The result now was, that the cache, containing the dependencies merged in a single file, was rebuild all the time, because the timestamp of that file couldn't be checked.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xabbuh@nicolas-grekas@SimonSimCity@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp