Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] fix assets and templating tests#17658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
isn't it still possible to disable the asset system if we don't need it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That would mean to revert#17506.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
shouldn't we remove alsosrc/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/assets_disabled.*?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, good catch. Thanks!
Now that the `assets` section is automatically enabled when `templating`is enabled (seesymfony#17506), the `templating.helper.assets` will also bepresent as soon as the `templating` section is activated.
fabpot commentedFeb 3, 2016
Thank you@xabbuh. |
This PR was merged into the 3.0 branch.Discussion----------[FrameworkBundle] fix assets and templating tests| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#17506| License | MIT| Doc PR |Now that the `assets` section is automatically enabled when `templating`is enabled (see#17506), the `templating.helper.assets` will also bepresent as soon as the `templating` section is activated.Commits-------293df5d [FrameworkBundle] fix assets and templating tests
Now that the
assetssection is automatically enabled whentemplatingis enabled (see#17506), the
templating.helper.assetswill also bepresent as soon as the
templatingsection is activated.