Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Try to delete broken symlinks#17626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
If you delete the target of a symlink (at least on Windows systems) youdon't get the kind of the target anymore (obviously). Therefore it mighthappen that a broken symlink to a directory should be removed withunlink() which fails. This patch adds another check for a broken symlinkand tries to remove with rmdir() before throwing an exception. It helpsto clean up test folders on Windows systems (so already proofed by theexisting tests).
5069c74 to58dd0b9CompareMember
xabbuh commentedFeb 3, 2016
Can you please add a test that would fail without this fix? Status: Needs work |
Member
fabpot commentedFeb 18, 2016
@IchHabRecht Can you add a unit test to cover the fix? Do you need help writing such a test? |
Member
nicolas-grekas commentedMar 2, 2016
Good catch, thanks@IchHabRecht. |
nicolas-grekas added a commit that referenced this pull requestMar 2, 2016
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17626).Discussion----------Try to delete broken symlinksIf you delete the target of a symlink (at least on Windows systems) youdon't get the kind of the target anymore (obviously). Therefore it mighthappen that a broken symlink to a directory should be removed withunlink() which fails. This patch adds another check for a broken symlinkand tries to remove with rmdir() before throwing an exception. It helpsto clean up test folders on Windows systems (so already proofed by theexisting tests).Commits-------8442ab1 [Filesystem] Try to delete broken symlinks
Member
stof commentedMar 2, 2016
@nicolas-grekas have you added a test to prevent regression on this ? |
Merged
This was referencedMar 25, 2016
Merged
Closed
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you delete the target of a symlink (at least on Windows systems) you
don't get the kind of the target anymore (obviously). Therefore it might
happen that a broken symlink to a directory should be removed with
unlink() which fails. This patch adds another check for a broken symlink
and tries to remove with rmdir() before throwing an exception. It helps
to clean up test folders on Windows systems (so already proofed by the
existing tests).