Settingnull as the version of a package means that it uses the empty
version strategy. However, omitting theversion option entirely was
meant to fall back to the default version strategy. This is not possible
when the default version value isnull as there is no way to remove
it.

remove default null value for asset version

25f735f

Setting `null` as the version of a package means that it uses the emptyversion strategy. However, omitting the `version` option entirely wasmeant to fall back to the default version strategy. This is not possiblewhen the default version value is `null` as there is no way to removeit.

carsonbot added the Status: Needs Review label

Jan 30, 2016

Copy link

MemberAuthor

xabbuh commentedJan 30, 2016

This will make tests of the FrameworkBundle pass again.

@ewgRa Can you have a look here as you initially added the default value in#17514 and I want to make sure not to break anything here which you intended to fix?

Copy link

MemberAuthor

xabbuh commentedJan 30, 2016

There are more broken tests in the FrameworkBundle which are not related to the Asset component. :(

xabbuh mentioned this pull request

Jan 30, 2016

[2.7] Fix tests#17582

Closed

Copy link

Member

fabpot commentedJan 30, 2016

Thank you@xabbuh.

fabpot merged commit25f735f intosymfony:2.7

Jan 30, 2016

fabpot added a commit that referenced this pull request

Jan 30, 2016

bug#17605[FrameworkBundle] remove default null value for asset vers…

8c0b48f

…ion (xabbuh)This PR was merged into the 2.7 branch.Discussion----------[FrameworkBundle] remove default null value for asset version| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Setting `null` as the version of a package means that it uses the emptyversion strategy. However, omitting the `version` option entirely wasmeant to fall back to the default version strategy. This is not possiblewhen the default version value is `null` as there is no way to removeit.Commits-------25f735f remove default null value for asset version

xabbuh deleted the default-assets-version-strategy branch

January 30, 2016 16:48

paradajozsef mentioned this pull request

Jan 30, 2016

Fix DependencyInjection tests#17594

Closed

fabpot mentioned this pull request

Feb 3, 2016

Release v3.0.2#17665

Merged

Copy link

Contributor

ewgRa commentedFeb 12, 2016

@xabbuh sorry for late reply, I miss this issue

My original commit was related tohttps://github.com/symfony/symfony/pull/16511/files#r50645726.
When I work on PR I miss defaultNull and in next fix-PR restore it.

Seems if tests working and "fall back to the default version strategy" is covered, than your fix right, but on first look seems it is broke BC.