Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Translation] Add resources from fallback locale to parent catalogue#17596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
41990b0 tof7f82faCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you can get catalogue from the translator without using reflection,$translator->getCatalogue('en')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not in branch2.3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yep 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
simplified inccc6d31 for 2.7.
fabpot commentedJan 31, 2016
Thank you@c960657. |
… catalogue (c960657)This PR was merged into the 2.3 branch.Discussion----------[Translation] Add resources from fallback locale to parent catalogue| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -The resources representing a locale includes those of the fallback locale. However, `getCatalogue()->getResources()` only returns the resources belonging specifically to the selected locale.Example: The locale `en_GB` falls back to `en`. I use the locale `en_GB`. During development, when I modify the `en_GB` translation file, the changes appear instantly when reloading the page. If I modify the `en` translation file, I need to manually clear the cache in order for the new translation to appear.I believe this is a regression that was introduced in#15527.This patch is for the 2.3 branch. For 2.6 and later, the test can be updated to use the getCatalogue() method instead of using ReflectionProperty.Commits-------f7f82fa [Translation] Add resources from fallback locale
The resources representing a locale includes those of the fallback locale. However,
getCatalogue()->getResources()only returns the resources belonging specifically to the selected locale.Example: The locale
en_GBfalls back toen. I use the localeen_GB. During development, when I modify theen_GBtranslation file, the changes appear instantly when reloading the page. If I modify theentranslation file, I need to manually clear the cache in order for the new translation to appear.I believe this is a regression that was introduced in#15527.
This patch is for the 2.3 branch. For 2.6 and later, the test can be updated to use the getCatalogue() method instead of using ReflectionProperty.