Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] simplify the BC layer#17565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The change to the `setFactoryService()` method is consistent with whatwe did with the `getFactoryService()` before (and how we handle thedeprecation of strict references in Symfony 2.8).
fabpot commentedJan 27, 2016
Thank you@xabbuh. |
This PR was merged into the 2.7 branch.Discussion----------[DependencyInjection] simplify the BC layer| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |The change to the `setFactoryService()` method is consistent with whatwe did with the `getFactoryService()` before (and how we handle thedeprecation of strict references in Symfony 2.8).Commits-------6cd5ee3 [DependencyInjection] simplify the BC layer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
didn't you forget to spread the new argument to the parent ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh good catch, we never call this internally so this went unnoticed. Would you like to send a fix?
…parent class (xabbuh)This PR was merged into the 2.7 branch.Discussion----------[DependencyInjection] pass triggerDeprecationError arg to parent class| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#17565 (comment)| License | MIT| Doc PR |Commits-------350625d pass triggerDeprecationError arg to parent class
The change to the
setFactoryService()method is consistent with whatwe did with the
getFactoryService()before (and how we handle thedeprecation of strict references in Symfony 2.8).