Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[SecurityBundle] Fix HTTP Digest auth not being passed user checker#17559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.8fromSamFleming:http_digest_fix
Jan 27, 2016
Merged

[SecurityBundle] Fix HTTP Digest auth not being passed user checker#17559

fabpot merged 1 commit intosymfony:2.8fromSamFleming:http_digest_fix
Jan 27, 2016

Conversation

@SamFleming
Copy link
Contributor

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

Wasn't sure if this was a bug so posted herehttp://stackoverflow.com/q/35022776/727236. However, after comparing the 2.3 branch and 2.8 branch I think it was a bug.

When trying to usehttp_digest on Symfony 2.8 you're greeted with the errorArgument 2 passed to Symfony\Component\Security\Core\Authentication\Provider\DaoAuthenticationProvider::__construct() must be an instance of Symfony\Component\Security\Core\User\UserCheckerInterface.

The exact samesecurity.yml works fine on v2.3.37.

Comparing the branches for the SecurityBundle I found that commit 05be5da1710ab681a04334d58126f8c3d431e3cb added the ability to configure a user checker on a per firewall basis. It seems that this commit seems to have missed updating the HttpDigestFactory (although it did update the other factories such as theHttpBasicFactory).

Testing this in my Symfony 2.8 app now works. However, I haven't been able to figure out what unit tests to write confirming this, does anyone with more experience on the SecurityBundle have any pointers?

Commit 05be5da1710ab681a04334d58126f8c3d431e3cb added the ability toconfigure a user checker on a per firewall basis. However, that commit seems tohave missed updating the HttpDigestFactory.
@fabpot
Copy link
Member

Thank you@SamFleming.

@fabpotfabpot merged commit517a9a2 intosymfony:2.8Jan 27, 2016
fabpot added a commit that referenced this pull requestJan 27, 2016
…r checker (SamFleming)This PR was merged into the 2.8 branch.Discussion----------[SecurityBundle] Fix HTTP Digest auth not being passed user checker| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Wasn't sure if this was a bug so posted herehttp://stackoverflow.com/q/35022776/727236. However, after comparing the 2.3 branch and 2.8 branch I think it was a bug.When trying to use `http_digest` on Symfony 2.8 you're greeted with the error `Argument 2 passed to Symfony\Component\Security\Core\Authentication\Provider\DaoAuthenticationProvider::__construct() must be an instance of Symfony\Component\Security\Core\User\UserCheckerInterface`.The exact same `security.yml` works fine on v2.3.37.Comparing the branches for the SecurityBundle I found that commit 05be5da1710ab681a04334d58126f8c3d431e3cb added the ability to configure a user checker on a per firewall basis. It seems that this commit seems to have missed updating the HttpDigestFactory (although it did update the other factories such as the [HttpBasicFactory](symfony/security-bundle@05be5da#diff-5f3e10fcc9de40dd09a8f3df3bdc9316)).Testing this in my Symfony 2.8 app now works. However, I haven't been able to figure out what unit tests to write confirming this, does anyone with more experience on the SecurityBundle have any pointers?Commits-------517a9a2 Fixed HTTP Digest auth not being passed user checker
@fabpotfabpot mentioned this pull requestFeb 3, 2016
@fabpotfabpot mentioned this pull requestFeb 28, 2016
@SamFlemingSamFleming deleted the http_digest_fix branchOctober 1, 2016 21:04
@SamFlemingSamFleming restored the http_digest_fix branchOctober 1, 2016 21:04
@SamFlemingSamFleming deleted the http_digest_fix branchOctober 1, 2016 21:06
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SamFleming@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp