@kucharovic I just tested your pull request and it works perfect! Thanks for working on this.

However, to make errors stand out more prominently, what do you think of using thesf-toolbar-status CSS classes that we use elsewhere in the toolbar. This way we could show the HTTP status like this:

If you like the idea, the code would be something like this:

varstatusCodeCell=document.createElement('td');varstatusCode=document.createElement('span');if(request.statusCode>299){statusCode.setAttribute('class','sf-toolbar-status sf-toolbar-status-red');}else{statusCode.setAttribute('class','sf-toolbar-status');}statusCode.textContent=request.statusCode||'-';statusCodeCell.appendChild(statusCode);row.appendChild(statusCodeCell);

@javiereguiluz it looks better. Are you sure, thatredirects should be red?

@kucharovic I trustedthis comment from@Jean85 who said that in Ajax there are no redirections. We probably need more comments about this or some verification.

IMO it should be:

if(request.statusCode<300){statusCode.setAttribute('class','sf-toolbar-status sf-toolbar-status-green');}elseif(request.statusCode<400){statusCode.setAttribute('class','sf-toolbar-status sf-toolbar-status-yellow');}else{statusCode.setAttribute('class','sf-toolbar-status sf-toolbar-status-red');}

@kucharovic anyway, to be completely safe, we could changeif (request.statusCode > 299) byif (request.statusCode > 399) and this will always work no matter what.

@javiereguiluzhe's right. A XMLHttpRequest should either get the resource or be told why not.

Hmmm, then maybe:

if(request.statusCode<400){statusCode.setAttribute('class','sf-toolbar-status sf-toolbar-status-green');}elseif(request.statusCode<500){statusCode.setAttribute('class','sf-toolbar-status sf-toolbar-status-yellow');}else{statusCode.setAttribute('class','sf-toolbar-status sf-toolbar-status-red');}

@stloyd I like your proposal ... except for the last comment. Showing 4xx errors in yellow is inconsistent with the current toolbar. 4xx and 5xx are treated as errors and showed in red.

Yeah, I posted that comment because I stumbled on it.. I had an issue in my code, since I was trying to catch redirects withjQuery.ajax() and I was getting always 200, didn't understand why :D

I agree with@javiereguiluz , consistency with the rest of the toolbar is better.

👍

should we really put the 2xx in green or keep it in gray instead ? I think putting colors only on errors make them stand out more than if everything is colored

For comparison:

Color on Errors

Color on Everything

+1 for gray instead of green

👍

Thank you@kucharovic.