Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Asset] Version as service#17532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ewgRa wants to merge3 commits intosymfony:masterfromewgRa:assets_version_as_service
Closed

[Asset] Version as service#17532

ewgRa wants to merge3 commits intosymfony:masterfromewgRa:assets_version_as_service

Conversation

@ewgRa
Copy link
Contributor

QA
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

While I working on#14832 I realize that all this problems and hidden magic can be avoided, if we will have ability to set asset version strategy as service.

This PR implementation of this idea.

Now it is possible to do something like this:

framework:assets:version_strategy:assets.custom_version_strategybase_urls:http://cdn.example.compackages:foo:base_urls:["https://example.com"]version_strategy:assets.custom_version_strategy

There is can be some conflicts with#16511 when it will be in master

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You cannot use both "version_strategy" and "version" at the same time under "assets".

@fabpot
Copy link
Member

👍

@ewgRa
Copy link
ContributorAuthor

@fabpot done, test fails seems unrelated (also appveyor marked as green, but it have failed tests)

Are you expect invalid message like this - "for the "{"base_urls":["//example.com"],"version":1,"version_strategy":"foo","version_format":null,"base_path":""}" package" ?

@fabpot
Copy link
Member

Packages have names, right?

@ewgRa
Copy link
ContributorAuthor

@fabpot right. But "thenInvalid" function just json encode node.

If you want package name under %s, I can check how it can be done.

@fabpot
Copy link
Member

If getting the package name is possible, that would be better, if not, just keep it without anything. Having the config in there would look weird.

@ewgRa
Copy link
ContributorAuthor

@fabpot I remove package name, maybe in next PR provide solution. On first look it is not so easy to output there package name.

@fabpot
Copy link
Member

Thank you@ewgRa.

@ewgRaewgRa deleted the assets_version_as_service branchJanuary 26, 2016 13:28
@fabpotfabpot mentioned this pull requestMay 13, 2016
xabbuh added a commit to symfony/symfony-docs that referenced this pull requestDec 13, 2016
This PR was merged into the 2.7 branch.Discussion----------Revert the merge of#7141I shouldn't have merged#7141 into the `2.7` branch as the related code PR (symfony/symfony#17532) was released with Symfony 3.1.Commits-------0f7c7d5 Revert "minor#7141 Added "How to Use a Custom Version Strategy for Assets" (teohhanhui, javiereguiluz)"
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ewgRa@fabpot@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp