Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[PropertyInfo] Use last version of reflection docblock#17531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
3249fd9 tob4c1a17CompareDo you know when version 3.0 will be out? If it's going to be before 3.1, we can definitely merge this. |
I don't know :/, i ask them herephpDocumentor/ReflectionDocBlock#70 |
Stable release ok for phpdocblock 3.0 Ready to review poke@dunglas (i believe your are in charge of this component ?) |
@joelwurtz this PR needs a rebase. Also, it looks like phpdocumentor/reflection-docblock 3.0.0 was released. |
| }, | ||
| "conflict": { | ||
| "phpdocumentor/reflection": "<1.0.7" | ||
| "phpdocumentor/reflection": "<3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you forgot to change the package name here
4251b83 to6829b8aCompareRebased and fix issues from feedback. |
| }, | ||
| "conflict": { | ||
| "phpdocumentor/reflection": "<1.0.7" | ||
| "phpdocumentor/reflection-docblock": "<3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we really need this? I don't think so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think also it make sense here as the suggest is only in the component not in main composer. However it can help user to know which version of this library is supported, but maybe not it's place in the main composer.
6829b8a tod642eaeCompareRebased on master and fix feedback, what about the conflict in the master composer.json ? |
Thank you@joelwurtz. |
… (joelwurtz)This PR was merged into the 3.1-dev branch.Discussion----------[PropertyInfo] Use last version of reflection docblock| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |This PR improve the PhpDocExtractor to usehttps://github.com/phpDocumentor/ReflectionDocBlock 3.0 dev branch instead ofhttps://github.com/phpDocumentor/ReflectionDocBlock 1.0.7 which is not maintained since 2014I don't know if it's a BC break since it's only a suggested dependency.This is somehow mandatory (we can maybe use a more stable, but also not maintained version of this repository) for#17516 as it does not have a dependency on php-parser 0.9.4 which is very old and not really suitable for the new component.Commits-------d642eae Use last version of reflection dockblock, avoid extra dependancy if library needed
…th the PHPDoc extractor (dunglas)This PR was merged into the 3.1-dev branch.Discussion----------[PropertyInfo] Allow to use a custom DocBlock factory with the PHPDoc extractor| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | yes| Deprecations? | yes| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aMinor tweak to#17531.Commits-------3c32a2f [PropertyInfo] Allow to use a custom DocBlock factory with the PHPDoc extractor
…ng reflection-docblock 3 (dunglas)This PR was squashed before being merged into the 3.1-dev branch (closes#17931).Discussion----------[FrameworkBundle] Fix PropertyInfo registration when using reflection-docblock 3| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | yes| Deprecations? | yes| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aCurrently, the PHPDoc extractor of PropertyInfo is not registered anymore because#17531 was merged.Commits-------6d31365 [FrameworkBundle] Fix PropertyInfo registration when using reflection-docblock 3
…dunglas)This PR was merged into the 3.1-dev branch.Discussion----------[PropertyInfo] Fix a BC break when the DocBlock is empty| Q | A| ------------- | ---| Branch | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aBC break introduced by#17531.Commits-------d2d8d17 [PropertyInfo] Fix a BC break when the DocBlock is empty
This PR improve the PhpDocExtractor to usehttps://github.com/phpDocumentor/ReflectionDocBlock 3.0 dev branch instead ofhttps://github.com/phpDocumentor/ReflectionDocBlock 1.0.7 which is not maintained since 2014
I don't know if it's a BC break since it's only a suggested dependency.
This is somehow mandatory (we can maybe use a more stable, but also not maintained version of this repository) for#17516 as it does not have a dependency on php-parser 0.9.4 which is very old and not really suitable for the new component.