Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] enable assets when templates are enabled#17506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This puts back the default behavior of Symfony 2.8 where the Assetcomponent features were implicitly configured with sensible defaultvalues when no explicit configuration was present but the templatingsection was enabled.
MemberAuthor
xabbuh commentedJan 23, 2016
Note, this must be merged into the |
Contributor
linaori commentedJan 23, 2016
Would this require |
Member
fabpot commentedJan 25, 2016
Thank you@xabbuh. |
fabpot added a commit that referenced this pull requestJan 25, 2016
… (xabbuh)This PR was submitted for the master branch but it was merged into the 3.0 branch instead (closes#17506).Discussion----------[FrameworkBundle] enable assets when templates are enabled| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#16570| License | MIT| Doc PR |This puts back the default behavior of Symfony 2.8 where the Assetcomponent features were implicitly configured with sensible defaultvalues when no explicit configuration was present but the templatingsection was enabled.Commits-------d0de425 enable assets when templates are enabled
xabbuh added a commit to xabbuh/symfony that referenced this pull requestFeb 2, 2016
Now that the `assets` section is automatically enabled when `templating`is enabled (seesymfony#17506), the `templating.helper.assets` will also bepresent as soon as the `templating` section is activated.
xabbuh added a commit to xabbuh/symfony that referenced this pull requestFeb 3, 2016
Now that the `assets` section is automatically enabled when `templating`is enabled (seesymfony#17506), the `templating.helper.assets` will also bepresent as soon as the `templating` section is activated.
fabpot added a commit that referenced this pull requestFeb 3, 2016
This PR was merged into the 3.0 branch.Discussion----------[FrameworkBundle] fix assets and templating tests| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#17506| License | MIT| Doc PR |Now that the `assets` section is automatically enabled when `templating`is enabled (see#17506), the `templating.helper.assets` will also bepresent as soon as the `templating` section is activated.Commits-------293df5d [FrameworkBundle] fix assets and templating tests
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts back the default behavior of Symfony 2.8 where the Asset
component features were implicitly configured with sensible default
values when no explicit configuration was present but the templating
section was enabled.