Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Asset] CLI: use request context to generate absolute URLs#17503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedJan 23, 2016
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15448 |
| License | MIT |
| Doc PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be kept (there is a reference in a@see annotation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catch, PhpStorm doesn't seem to handle that properly. I changed the annotation to use the FQCN instead. Okay for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No, we are using short class names everywhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
okay, I reverted this one
fabpot commentedJan 23, 2016
👍 |
e72f7d0 to766a648Comparejaviereguiluz commentedJan 23, 2016
@xabbuh a very nice solution for a very demanded feature. Thanks! |
fabpot commentedJan 23, 2016
Thank you@xabbuh. |
… (xabbuh)This PR was merged into the 2.7 branch.Discussion----------[Asset] CLI: use request context to generate absolute URLs| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#15448| License | MIT| Doc PR |Commits-------766a648 CLI: use request context to generate absolute URLs