Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[2.7] [FrameworkBundle] [DX] Sort bundles in config commands#17495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
xabbuh commentedJan 22, 2016
👍 Status: Reviewed I think we should do something similar in theConfigDumpReferenceCommand for the |
Contributor
paradajozsef commentedJan 22, 2016
👍 |
Member
fabpot commentedJan 23, 2016
Thank you@kix. |
fabpot added a commit that referenced this pull requestJan 23, 2016
…ands (kix)This PR was merged into the 2.7 branch.Discussion----------[2.7] [FrameworkBundle] [DX] Sort bundles in config commands| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | noneReopened against `2.7` instead of#17490This makes the behaviour of config commands a bit more user-friendly. Scanning through an ordered list should be a lot easier for the user, especially if she knows what's the exact bundle they're looking for. The sort is applied to the bundle name, as the extension alias might not always be present.Before:After:Commits-------80d51e0 Sort bundles in config commands
ContributorAuthor
kix commentedJan 23, 2016
Thanks for the merge! |
xabbuh added a commit to xabbuh/symfony that referenced this pull requestJan 23, 2016
This backportssymfony#17495 to the `2.3` branch.
fabpot added a commit that referenced this pull requestJan 25, 2016
This PR was merged into the 2.3 branch.Discussion----------sort bundles in config:dump-reference command| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |This backports#17495 to the `2.3` branch.Commits-------a5c8811 sort bundles in config:dump-reference command
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopened against
2.7instead of#17490This makes the behaviour of config commands a bit more user-friendly. Scanning through an ordered list should be a lot easier for the user, especially if she knows what's the exact bundle they're looking for. The sort is applied to the bundle name, as the extension alias might not always be present.
Before:
After: