Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] make tests compatible with Symfony 2.8 and 3.0#17463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedJan 20, 2016
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
paradajozsef commentedJan 20, 2016
@xabbuh Thank you!! (you were faster than me with this PR) :) It was my mistake. The test I created here:#17406 was only compatible with 2.7, but was merged to 2.8 and 3.0 too. Next time I have to check test in newer versions also. Sorry for that! (Also interesting, that the AppVeyor build was successful when there was a failing test. I create an issue for that.) 👍 Status: Reviewed |
xabbuh commentedJan 20, 2016
@paradajozsef There was nothing wrong with your pull request. Referencing form types by their qualified class names does only work since Symfony 2.8 so we exactly had to do what you did in your PR. :) |
paradajozsef commentedJan 20, 2016
@xabbuh I see. Thanks for the reply! :) |
fabpot commentedJan 21, 2016
Thank you@xabbuh. |
…buh)This PR was merged into the 2.8 branch.Discussion----------[Form] make tests compatible with Symfony 2.8 and 3.0| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Commits-------4d2930e make tests compatible with Symfony 2.8 and 3.0
This PR was merged into the 3.1-dev branch.Discussion----------[Form] Make tests compatible with master| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -I wrote tests in this PR:#17406 which was compatible only with 2.7.@xabbuh fixed it in 2.8 and 3.0 here:#17463. And this PR fixes deprecated notices in master.Kind of an unfortunate situation...Commits-------96e40b2 Fix unit tests in master