Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Serializer] Ensure that groups are strings#17430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
dunglas wants to merge3 commits intosymfony:2.7fromdunglas:sr_yaml_groups

Conversation

@dunglas
Copy link
Member

QA
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsn/a
LicenseMIT
Doc PRn/a

@paradajozsef
Copy link
Contributor

👍

One more thing to note. If such a yml is provided to the loader:

Acme\MyObj:attributes:foo:groups:'group1'

Invalid argument supplied for foreach() warning raises, because it isnot ensured here.

If you think this should be in another PR, than sorry. :)

@dunglas
Copy link
MemberAuthor

Good catch@paradajozsef, I've added a separate commit in this PR.

@paradajozsef
Copy link
Contributor

👍

@GuilhemN
Copy link
Contributor

This is more a bug fix than a new feature ;-)

👍 debugging is easier with this kind of check 😄

@xabbuh
Copy link
Member

We should include the name of the file and probably some other related information (class name, property or something like that) to make it easier to spot the place where the configuration is wrong.

@fabpot
Copy link
Member

I agree with@xabbuh

@dunglas
Copy link
MemberAuthor

Status: Need Review

@xabbuh@fabpot done

@fabpot
Copy link
Member

Thank you@dunglas.

fabpot added a commit that referenced this pull requestJan 26, 2016
This PR was squashed before being merged into the 2.7 branch (closes#17430).Discussion----------[Serializer] Ensure that groups are strings| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aCommits-------0a3b877 [Serializer] Ensure that groups are strings
@fabpotfabpot closed thisJan 26, 2016
@dunglasdunglas deleted the sr_yaml_groups branchJanuary 26, 2016 07:01
@fabpotfabpot mentioned this pull requestFeb 3, 2016
This was referencedFeb 28, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dunglas@paradajozsef@GuilhemN@xabbuh@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp