Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] Ensure that groups are strings#17430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dunglas commentedJan 18, 2016
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
paradajozsef commentedJan 18, 2016
👍 One more thing to note. If such a yml is provided to the loader: Acme\MyObj:attributes:foo:groups:'group1'
If you think this should be in another PR, than sorry. :) |
dunglas commentedJan 19, 2016
Good catch@paradajozsef, I've added a separate commit in this PR. |
paradajozsef commentedJan 19, 2016
👍 |
GuilhemN commentedJan 19, 2016
This is more a bug fix than a new feature ;-) 👍 debugging is easier with this kind of check 😄 |
xabbuh commentedJan 19, 2016
We should include the name of the file and probably some other related information (class name, property or something like that) to make it easier to spot the place where the configuration is wrong. |
fabpot commentedJan 25, 2016
I agree with@xabbuh |
dunglas commentedJan 26, 2016
fabpot commentedJan 26, 2016
Thank you@dunglas. |
This PR was squashed before being merged into the 2.7 branch (closes#17430).Discussion----------[Serializer] Ensure that groups are strings| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aCommits-------0a3b877 [Serializer] Ensure that groups are strings