Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fixed Bootstrap form theme form "reset" buttons#17418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
Tobion commentedJan 18, 2016
👍 Status: Reviewed |
Member
fabpot commentedJan 19, 2016
Thank you@javiereguiluz. |
fabpot added a commit that referenced this pull requestJan 19, 2016
…iluz)This PR was merged into the 2.7 branch.Discussion----------Fixed Bootstrap form theme form "reset" buttons| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#14290| License | MIT| Doc PR | -All the credit for this solution goes to@AntonioAmore, who reported the error originally and provided a solution. I only confirmed the bug and verified the proposed solution.Commits-------67c7f05 Fixed Bootstrap form theme form "reset" buttons
javiereguiluz added a commit to EasyCorp/EasyAdminBundle that referenced this pull requestJan 19, 2016
This PR was merged into the master branch.Discussion----------Improved the form theme for "reset" buttonsThis is the same change proposed for the official Symfony form theme:symfony/symfony#17418Commits-------0207732 Improved the form theme for "reset" buttons
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the credit for this solution goes to@AntonioAmore, who reported the error originally and provided a solution. I only confirmed the bug and verified the proposed solution.