Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[TwigBridge] Use label_format option for checkbox and radio labels#17380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
enumag commentedJan 14, 2016
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
xabbuh commentedJan 14, 2016
👍 Is this the only place where we need to make this change? Status: Reviewed |
enumag commentedJan 14, 2016
Not sure I'll take a look at the other files. |
enumag commentedJan 14, 2016
@xabbuh Turns out we should do the same in the twig template for foundation 5. However since it is not present in 2.7 I can't include the change in this PR. Should I open a second one? |
xabbuh commentedJan 14, 2016
@enumag Would be great if you were able to do that. 👍 |
enumag commentedJan 14, 2016
Tobion commentedJan 14, 2016
Ref#12050 for the original PR. 👍 |
enumag commentedJan 14, 2016
Tobion commentedJan 14, 2016
No that was just for anyone reviewing the code |
fabpot commentedJan 15, 2016
Thank you@enumag. |
…o labels (enumag)This PR was merged into the 2.7 branch.Discussion----------[TwigBridge] Use label_format option for checkbox and radio labels| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Commits-------dc8f780 [TwigBridge] Use label_format option for checkbox and radio labels