NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Form] fixed false value being converted to an empty string in ChoiceArrayList#17372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ivoaz wants to merge1 commit intosymfony:2.7fromivoaz:ticket_17292

Closed

[Form] fixed false value being converted to an empty string in ChoiceArrayList#17372

ivoaz wants to merge1 commit intosymfony:2.7fromivoaz:ticket_17292

Conversation

Copy link

ivoaz commentedJan 14, 2016

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#17292
License	MIT
Doc PR

Whenfalse value is used as a choice value, it is converted to an empty string,
which conflicts with the empty value, if the choice is optional. If the choice
is not optional, then there may be problems with html validation, since required
choice does not allow empty value to be submitted.

This patch disables value casting to string, if the choices containfalse value.

[Form] fixed false value being converted to an empty string in Choice…

c5778b0

…ArrayListWhen `false` value is used as a choice value, it is converted to an empty string,which conflicts with the empty value, if the choice is optional. If the choiceis not optional, then there may be problems with html validation, since requiredchoice does not allow empty value to be submitted.This patch disables value casting to string, when the choice contains values,that would be converted to an empty string.

carsonbot added the Status: Needs Review label

Jan 14, 2016

Copy link

Member

xabbuh commentedJan 14, 2016

I am not sure if this is the right fix but we would need a test in any case that ensures we do not break the behaviour again in the future.

xabbuh added the Form label

Jan 14, 2016

Copy link

ivoazm commentedJan 15, 2016

Actually, when usingfalse as a key of an array, it is converted to0, not empty string, like casting to string does.

Better solution would be then to convertfalse value to0, instead of casting it to string. This would be consistent with how it worked before withchoices_as_values => false.
What do you think?