Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Display console application name even when no version set#17326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
else is not required here.
nicolas-grekas commentedJan 13, 2016
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
More clear would be IMO:
if ('UNKNOWN' !==$this->getName()) {if ('UNKNOWN' !==$this->getVersion()) {returnsprintf('<info>%s</info> version <comment>%s</comment>',$this->getName(),$this->getVersion()); }returnsprintf('<info>%s</info>',$this->getName());}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's what I had done at first but I thought I was less clear. Anyway I can change no problems !
dunglas commentedJan 14, 2016
👍 |
fabpot commentedJan 14, 2016
Thank you@polc. |
…rsion set (polc)This PR was squashed before being merged into the 2.3 branch (closes#17326).Discussion----------[Console] Display console application name even when no version set| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| License | MITWhen displaying help of an Application with a name but no version, it show "Console Tool" instead of the application name.Commits-------61e810e [Console] Display console application name even when no version set
When displaying help of an Application with a name but no version, it show "Console Tool" instead of the application name.