Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix max width for multibyte keys in choice question#17314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
marek-pietrzak-tg wants to merge3 commits intosymfony:2.8frommarek-pietrzak-tg:fix-max-width-for-choice-question
Closed
Fix max width for multibyte keys in choice question#17314
marek-pietrzak-tg wants to merge3 commits intosymfony:2.8frommarek-pietrzak-tg:fix-max-width-for-choice-question
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedJan 13, 2016
👍 |
Member
fabpot commentedJan 14, 2016
Thank you @mheki. |
fabpot added a commit that referenced this pull requestJan 14, 2016
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes#17314).Discussion----------Fix max width for multibyte keys in choice questionFixes wrong key max width for ChoiceQuestion in multibyte stringsBefore:After:To replicate you can use this code as an example:```namespace AppBundle\Command;use Symfony\Component\Console\Command\Command;use Symfony\Component\Console\Input\InputInterface;use Symfony\Component\Console\Output\OutputInterface;use Symfony\Component\Console\Question\ChoiceQuestion;class QuesionCommand extends Command{ protected function configure() { $this->setName('app:question'); $this->setDescription('Command for testing PR'); } protected function execute(InputInterface $input, OutputInterface $output) { $helper = $this->getHelper('question'); $question = new ChoiceQuestion('Choose something:', [ 'foo' => 'foo', 'żółw' => 'bar', 'łabądź' => 'baz', 'известно' => 'lorem', 'газета' => 'ipsum', ], 0); $colour = $helper->ask($input, $output, $question); $output->writeln('you have chosen: ' . $colour); }}```| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#15368| License | MIT| Doc PR | -Commits-------5d2463b Fix max width for multibyte keys in choice question
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wrong key max width for ChoiceQuestion in multibyte strings
Before:

After:

To replicate you can use this code as an example: