Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Fix paths with % in it (like urlencoded)#17307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.3fromscaytrase:2.3
Jan 11, 2016
Merged

[FrameworkBundle] Fix paths with % in it (like urlencoded)#17307

fabpot merged 1 commit intosymfony:2.3fromscaytrase:2.3
Jan 11, 2016

Conversation

@scaytrase
Copy link
Contributor

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?Travis passed
Fixed tickets#17306
LicenseMIT
Doc PRnone

@scaytrasescaytrase changed the titleFix paths with % in it (like urlencoded)[FrameworkBundle] Fix paths with % in it (like urlencoded)Jan 8, 2016
@dosten
Copy link
Contributor

This is a BC break, you need to manually escape the % char

@scaytrase
Copy link
ContributorAuthor

@dosten How should this be a BC break? Kernel parameter% signs are resolved before. And all other% should be passed as is to the sprintf. In other case they cause Exception (see the bug attached)

@scaytrase
Copy link
ContributorAuthor

i.e if we have path/var/www/some%2Fproject/ (which is'/var/www/' . urlencode('some/project')) we will have the exception. Passign% as is should not be a BC break as sprintf expects only one%s template in the path.

@Tobion
Copy link
Contributor

The better fix is to only apply thesprintf to/Resources/%s/translations and not the kernel root dir. This way there is no need to encode anything.

@scaytrase
Copy link
ContributorAuthor

@Tobion Yes, and this would have more clear logic with sprifntf.

Does this one looks better?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

line 575 can reuse $rootDir

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@Tobion updated

@Tobion
Copy link
Contributor

👍

Status: Reviewed

@fabpot
Copy link
Member

Thank you@scaytrase.

@fabpotfabpot merged commitde7b4d7 intosymfony:2.3Jan 11, 2016
fabpot added a commit that referenced this pull requestJan 11, 2016
… (scaytrase)This PR was merged into the 2.3 branch.Discussion----------[FrameworkBundle] Fix paths with % in it (like urlencoded)| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | Travis passed| Fixed tickets |#17306| License       | MIT| Doc PR        | noneCommits-------de7b4d7Fix#17306 Paths with % in it are note allowed (like urlencoded)
@scaytrasescaytrase deleted the 2.3 branchJanuary 11, 2016 10:09
@scaytrasescaytrase restored the 2.3 branchJanuary 11, 2016 10:09
This was referencedJan 14, 2016
@fabpotfabpot mentioned this pull requestFeb 3, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@scaytrase@dosten@Tobion@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp