Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[VarDumper] Add flags to allow fine tuning dumps representation#17305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
repreesentation ->representation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed thx
056c866 toee4f8a9Comparenicolas-grekas commentedJan 12, 2016
ping @symfony/deciders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would prefer swapping the arguments (imo that's more readable).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
swapped
dunglas commentedJan 14, 2016
Status: reviewed 👍 |
xabbuh commentedJan 14, 2016
👍 |
…sentation (nicolas-grekas)This PR was merged into the 3.1-dev branch.Discussion----------[VarDumper] Add flags to allow fine tuning dumps representation| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#15856| License | MIT| Doc PR | -The `DUMP_STRING_LENGTH` behavior has been requested in#15856,the `DUMP_LIGHT_ARRAY` behavior is what should have been done for the VarDumperTestTrait. Anticipated usage is opt-in, by adding `<env name="DUMP_LIGHT_ARRAY" value="1" />` in `phpunit.xml.dist`.Any more flags proposal anyone? Better names maybe?Commits-------a35ceb0 [VarDumper] Add flags to allow fine tuning dumps representation
The
DUMP_STRING_LENGTHbehavior has been requested in#15856,the
DUMP_LIGHT_ARRAYbehavior is what should have been done for the VarDumperTestTrait. Anticipated usage is opt-in, by adding<env name="DUMP_LIGHT_ARRAY" value="1" />inphpunit.xml.dist.Any more flags proposal anyone? Better names maybe?