Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Allow to autowire service_container#17261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.8fromdunglas:service_container_autowire
Jan 5, 2016

Conversation

@dunglas
Copy link
Member

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#17252
LicenseMIT
Doc PRn/a

@ad3n
Copy link

ad3n commentedJan 5, 2016

👍 thanks kevin@dunglas

@nicolas-grekas
Copy link
Member

👍

@fabpot
Copy link
Member

Thank you@dunglas.

@fabpotfabpot merged commit4e2eef0 intosymfony:2.8Jan 5, 2016
fabpot added a commit that referenced this pull requestJan 5, 2016
…glas)This PR was merged into the 2.8 branch.Discussion----------[FrameworkBundle] Allow to autowire service_container| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#17252| License       | MIT| Doc PR        | n/aCommits-------4e2eef0 [FrameworkBundle] Allow to autowire service_container
@fabpotfabpot mentioned this pull requestJan 14, 2016
@fabpotfabpot mentioned this pull requestFeb 3, 2016
@dunglasdunglas deleted the service_container_autowire branchMarch 12, 2016 17:07
fabpot added a commit that referenced this pull requestMar 12, 2016
…or of other services (weaverryan)This PR was merged into the 2.8 branch.Discussion----------Autowiring the concrete class too - consistent with behavior of other services| Q             | A| ------------- | ---| Branch        | 2.8| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#18132| License       | MIT| Doc PR        | n/aThis follows#17261. Without this, if you use the concrete class `Container`, it doesn't autowire, so it creates a *new* one. That is certainly not what the end-user wants, and it's a serious WTF :). We can talk all day long about not injecting the container and type-hinting interfaces, but this is needed to be consistent with how all the other services in the container work and to avoid this odd behavior.Thanks!Commits-------2ea3f68 Autowiring the concrete class too - consistent with behavior of other services
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dunglas@ad3n@nicolas-grekas@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp