Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Fixed violation mapping if multiple forms are using the same (or part of the same) property path#17099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
alekitto commentedDec 21, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #5656 |
| License | MIT |
| Doc PR |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we usually prefer yoda style (swapping left and right hands of comparisons)
…or part of the same) property path| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |symfony#5656| License | MIT| Doc PR |
ContributorAuthor
alekitto commentedDec 28, 2015
@nicolas-grekas: ok, comparisons edited as you suggested |
Member
fabpot commentedFeb 15, 2016
Thank you@alekitto. |
fabpot added a commit that referenced this pull requestFeb 15, 2016
… the same (or part of the same) property path (alekitto)This PR was squashed before being merged into the 2.3 branch (closes#17099).Discussion----------[Form] Fixed violation mapping if multiple forms are using the same (or part of the same) property path| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#5656| License | MIT| Doc PR |Commits-------f005c80 [Form] Fixed violation mapping if multiple forms are using the same (or part of the same) property path
fabpot added a commit that referenced this pull requestFeb 17, 2016
This PR was merged into the 2.7 branch.Discussion----------[Form] fix violation mapper tests| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#17099| License | MIT| Doc PR |This takes into account the changes to the `getErrors()` in Symfony 2.5(the method rturns a `FormErrorIterator` instead of an array) as well asthe fact that non-submitted forms do not accept errors since#10567anymore.Commits-------f87558d [Form] fix violation mapper tests
This was referencedFeb 28, 2016
Merged
Merged
Merged
Merged
fabpot added a commit that referenced this pull requestMay 13, 2016
… false in ViolationMapper (issei-m)This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes#18747).Discussion----------[2.8] [Form] Modified iterator_to_array's 2nd parameter to false in ViolationMapper| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aThis bug was introduced in PR#17099. So does not represent in 2.8.2 or older.If we have the following structure form:```php$builder = $formFactory->createBuilder();$form = $builder ->add( $builder->create('person1_name', FormType::class, ['inherit_data' => true]) ->add('first', TextType::class, ['property_path' => '[person1_first_name]']) ->add('last', TextType::class, ['property_path' => '[person1_last_name]']) ) ->add( $builder->create('person2_name', FormType::class, ['inherit_data' => true]) ->add('first', TextType::class, ['property_path' => '[person2_first_name]']) ->add('last', TextType::class, ['property_path' => '[person2_last_name]']) ) ->getForm();```The following mapping for this form doesn't work correctly:```php$mapper = new ViolationMapper();$mapper->mapViolation(new ConstraintViolation('', '', [], null, 'data[person1_first_name]', null), $form);$form['person1_name']['first']->getErrors(); // empty$form->getErrors(); // The violation is mapped to here instead.```## CauseBecause ViolationMapper uses `iterator_to_array` in [here](https://github.com/symfony/symfony/blob/f29d46f29b91ea5c30699cf6bdb8e65545d1dd26/src/Symfony/Component/Form/Extension/Validator/ViolationMapper/ViolationMapper.php#L165) to collect the sub forms.`person1_name` and `person2_name` enable `inherit_data` option. So ViolationMapper will attempt to collect the sub forms of root form like this:```php[ 'first' => Form object, // root.person1_name.first 'last' => Form object, // root.person1_name.last 'first' => Form object, // root.person2_name.first 'last' => Form object, // root.person2_name.last]```As you can see, The name `first` and `last` are used in two places, thus we cannot get result like that.(first/last of person1_name are overwritten by person2_name's)So the violation will finally lost the form where it should map to. It should pass `false` to `iterator_to_array`'s 2nd parameter.Commits-------ae38660 [2.8] [Form] Modified iterator_to_array's 2nd parameter to false in ViolationMapper
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.