Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix constraint validator alias being required#17074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Mx-Glitter wants to merge1 commit intosymfony:masterfromMx-Glitter:fix-constraint-validator-alias-required
Closed
Fix constraint validator alias being required#17074
Mx-Glitter wants to merge1 commit intosymfony:masterfromMx-Glitter:fix-constraint-validator-alias-required
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedDec 19, 2015
Member
nicolas-grekas commentedDec 28, 2015
@Triiistan could you please rebase to trigger tests again? |
284448c toee52483CompareContributorAuthor
Mx-Glitter commentedDec 28, 2015
@nicolas-grekas Done |
ee52483 to77c63d2CompareContributorAuthor
Mx-Glitter commentedJan 24, 2016
Fixed a typo + rebased again |
Member
fabpot commentedJan 25, 2016
Shouldn't this be merged into older branches? It can be seen as a bug fix as having to repeat the class under the alias item seems useless. |
Member
fabpot commentedJan 25, 2016
👍 |
ContributorAuthor
Mx-Glitter commentedJan 25, 2016
I did that because the current behavior isalready documented, so I supposed this was a new feature. But I agree with you that it looks like a bug fix. |
Member
fabpot commentedJan 25, 2016
It's indeed documented as being required, so making that optional is not really a problem IMHO. |
Member
javiereguiluz commentedFeb 22, 2016
This contribution looks finished. Do Symfony mergers want@Triiistan to create a new pull request against 2.3 .... or can you merge this into older branches? Thanks! |
Member
xabbuh commentedFeb 23, 2016
👍 |
Member
fabpot commentedFeb 23, 2016
Thank you@Triiistan. |
fabpot added a commit that referenced this pull requestFeb 23, 2016
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17074).Discussion----------Fix constraint validator alias being required| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#16805| License | MIT| Doc PR |symfony/symfony-docs#6055This is my first contribution, so everything might not be in perfect order.Follow-up of#16841 on the right branch.Commits-------5136c30 Fix constraint validator alias being required
This was referencedFeb 28, 2016
Merged
Merged
Merged
Merged
weaverryan added a commit to symfony/symfony-docs that referenced this pull requestApr 26, 2016
This PR was merged into the 2.3 branch.Discussion----------Document constraint validator alias optional| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no (symfony/symfony#17074)| Applies to | 2.3| Fixed tickets |Same as#6055 but on the 2.3 branch as the relevant Symfony PRsymfony/symfony#17074 was merged on 2.3.Commits-------873ede0 Document constraint validator alias optional
weaverryan added a commit to symfony/symfony-docs that referenced this pull requestJul 10, 2016
weaverryan added a commit to symfony/symfony-docs that referenced this pull requestAug 2, 2016
weaverryan added a commit to symfony/symfony-docs that referenced this pull requestAug 2, 2016
…ymfony#17074 (weaverryan)This PR was merged into the 2.7 branch.Discussion----------Removing the alias stuff - not required aftersymfony/symfony#17074Thanks tosymfony/symfony#17074 (merged all the way back into 2.3), `alias` is not required anymore. So why mention it?As I understand it, validators work like the new form types: it's ok that `validatedBy returns a class name: the validation system will notice that you have a tagged service matching this class and will use that instead of creating it new.Commits-------31afb0e line break2ec049d Removing the alias stuff - not required aftersymfony/symfony#17074
weaverryan added a commit to symfony/symfony-docs that referenced this pull requestAug 2, 2016
* 2.7: (51 commits) this sounds just a little bit more natural Update dynamic_form_modification.rst Remove colloquialism "hold on" fixing reference to deprecated class removing use statement for consistency with other places in this doc fix FlattenException namespace Tweaks thanks to close review from Javier and@snoek09! Remove AcmeDemoBundle references Fix reference to output object Subject-verb agreement Fix tense and sentence length Fix typo in external_parameters.rst line break Removing the alias stuff - not required aftersymfony/symfony#17074 Fixed the main index page redirections Fixed the redirection for "upgrade" articles Added all the missing "index pages" redirections Fixed a Console article redirection Fixed the redirection of the previous "performance" book chapter Fixed a DI redirection ...
weaverryan added a commit to symfony/symfony-docs that referenced this pull requestAug 2, 2016
* 2.8: (52 commits) this sounds just a little bit more natural Update dynamic_form_modification.rst Remove colloquialism "hold on" fixing reference to deprecated class removing use statement for consistency with other places in this doc fix FlattenException namespace Tweaks thanks to close review from Javier and@snoek09! Remove AcmeDemoBundle references Fix reference to output object Subject-verb agreement fixed missing level in namespace Fix tense and sentence length Fix typo in external_parameters.rst line break Removing the alias stuff - not required aftersymfony/symfony#17074 Fixed the main index page redirections Fixed the redirection for "upgrade" articles Added all the missing "index pages" redirections Fixed a Console article redirection Fixed the redirection of the previous "performance" book chapter ...
weaverryan added a commit to symfony/symfony-docs that referenced this pull requestAug 2, 2016
* 3.0: (52 commits) this sounds just a little bit more natural Update dynamic_form_modification.rst Remove colloquialism "hold on" fixing reference to deprecated class removing use statement for consistency with other places in this doc fix FlattenException namespace Tweaks thanks to close review from Javier and@snoek09! Remove AcmeDemoBundle references Fix reference to output object Subject-verb agreement fixed missing level in namespace Fix tense and sentence length Fix typo in external_parameters.rst line break Removing the alias stuff - not required aftersymfony/symfony#17074 Fixed the main index page redirections Fixed the redirection for "upgrade" articles Added all the missing "index pages" redirections Fixed a Console article redirection Fixed the redirection of the previous "performance" book chapter ...
weaverryan added a commit to symfony/symfony-docs that referenced this pull requestAug 2, 2016
* 3.1: (52 commits) this sounds just a little bit more natural Update dynamic_form_modification.rst Remove colloquialism "hold on" fixing reference to deprecated class removing use statement for consistency with other places in this doc fix FlattenException namespace Tweaks thanks to close review from Javier and@snoek09! Remove AcmeDemoBundle references Fix reference to output object Subject-verb agreement fixed missing level in namespace Fix tense and sentence length Fix typo in external_parameters.rst line break Removing the alias stuff - not required aftersymfony/symfony#17074 Fixed the main index page redirections Fixed the redirection for "upgrade" articles Added all the missing "index pages" redirections Fixed a Console article redirection Fixed the redirection of the previous "performance" book chapter ...
weaverryan added a commit to symfony-tools/docs-builder that referenced this pull requestDec 23, 2018
* 2.7: (51 commits) this sounds just a little bit more natural Update dynamic_form_modification.rst Remove colloquialism "hold on" fixing reference to deprecated class removing use statement for consistency with other places in this doc fix FlattenException namespace Tweaks thanks to close review from Javier and@snoek09! Remove AcmeDemoBundle references Fix reference to output object Subject-verb agreement Fix tense and sentence length Fix typo in external_parameters.rst line break Removing the alias stuff - not required aftersymfony/symfony#17074 Fixed the main index page redirections Fixed the redirection for "upgrade" articles Added all the missing "index pages" redirections Fixed a Console article redirection Fixed the redirection of the previous "performance" book chapter Fixed a DI redirection ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first contribution, so everything might not be in perfect order.
Follow-up of#16841 on the right branch.