Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] fix BC break introduced with prototype_data option#17044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should betype
memphys commentedDec 17, 2015
@HeahDude thanks! Made new commit, now test is passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Symfony CS prefers to use Yoda conditions:if (null !== $options['prototype_data']) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@sstok thanks! Fixed
nicolas-grekas commentedDec 18, 2015
👍 |
fabpot commentedDec 18, 2015
Thank you@memphys. |
…(memphys)This PR was squashed before being merged into the 2.8 branch (closes#17044).Discussion----------[Form] fix BC break introduced with prototype_data option| Q | A| ------------- | ---| Bug fix? | [yes]| New feature? | [no]| BC breaks? | [no]| Deprecations? | [no]| Tests pass? | [no]| Fixed tickets | [#15707]| License | MIT| Doc PR | []This fixes the BC break introduced with prototype_data option in collection type. At the moment whether option is set or not it overwrites prototype data but it has different behaviour before and prototype data was taken from the mapped form data/entity.- [x] make the test work (can't figure yet how to test that prototype without prototype_data option has default values)Commits-------d73485a [Form] fix BC break introduced with prototype_data option
memphys commentedDec 18, 2015
@fabpot with pleasure! |
This PR was merged into the 2.8 branch.Discussion----------[Form] Fix regression on Collection typeQ | A--- | ---Bug fix? | yesNew feature? | noBC breaks? | noDeprecations? | noTests pass? | yesFixed tickets |License | MITDoc PR |A regression was introduced in#17044.Commits-------bd686cd [Form] Fixed regression on Collection type
This fixes the BC break introduced with prototype_data option in collection type. At the moment whether option is set or not it overwrites prototype data but it has different behaviour before and prototype data was taken from the mapped form data/entity.