NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[FrameworkBundle] Add APCu support for the Serializer#17025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

dunglas wants to merge1 commit intosymfony:masterfromdunglas:apcu

Closed

[FrameworkBundle] Add APCu support for the Serializer#17025

dunglas wants to merge1 commit intosymfony:masterfromdunglas:apcu

Conversation

Copy link

Member

dunglas commentedDec 16, 2015

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

This PR configures support for the new APCu class from Doctrine Cache (doctrine/cache#115) for the Serializer service.
I'll open a similar PR for the validator service when#16822 will be merged.

I've opened it against master as a new feature, but maybe must it be merged in older versions (2.3?) and considered as a bug fix: APCu for PHP7 doesn't support the APC API anymore. So Symfony projects migrating to PHP7 will not be able to use metadata cache (mandatory in production) without APCu support or adding manually some services.

[FrameworkBundle] Add APCu support

ebf1951

dunglas added the FrameworkBundle label

Dec 16, 2015

carsonbot added the Status: Needs Review label

Dec 16, 2015

Copy link

layanto commentedDec 16, 2015

Why is this service named serializer.mapping.cache.apcu instead of serializer.mapping.cache.doctrine.apcu like#16822 ?

Copy link

Contributor

ogizanagi commentedDec 16, 2015

@layanto : IMO theserializer.mapping.cache.apcu service id is fine.
Thevalidator.mapping.cache.doctrine.apc was named like this because we were unable to name itvalidator.mapping.cache.apc as this last one already exists. Thedoctrine part in it isn't so much important, and short ids are better.

But we won't have any issue to name the new APCu implementationvalidator.mapping.cache.apcu. So don't worry, it'll stay consistent.

Copy link

layanto commentedDec 16, 2015

I too do not like overly long name but I think it is confusing that validator.mapping.cache.apc is deprecated in favour of validator.mapping.cache.doctrine.apc and then this adds validator.mapping.cache.apcu which is very similar to the deprecated name.