NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpKernel] HttpCache: remove an ESI instance checking#16970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Tobion merged 1 commit intosymfony:3.0fromvoronkovich:remove_esi_check

Dec 12, 2015

Merged

[HttpKernel] HttpCache: remove an ESI instance checking#16970

Tobion merged 1 commit intosymfony:3.0fromvoronkovich:remove_esi_check

Dec 12, 2015

Conversation

Copy link

Contributor

voronkovich commentedDec 11, 2015

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	no
License	MIT
Doc PR	no

This checking was added by this commit32d964b, but now it's not needed

Removed ESI instance check

7528134

carsonbot added the Status: Needs Review label

Dec 11, 2015

Copy link

Contributor

aitboudad commentedDec 11, 2015

👍

Status: Reviewed

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Dec 11, 2015

Tobion reviewed

Dec 11, 2015

View reviewed changes

src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php

Copy link

Contributor

TobionDec 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What iscreateSurrogate? I cannot find such definition. this exception still doesn't make sense to me in 2.7
Ref.#15306 (comment)

Copy link

ContributorAuthor

voronkovichDec 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@Tobion,createSurrogate is herehttps://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/HttpCache/HttpCache.php#L73

Copy link

Contributor

TobionDec 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

but that is in frameworkbundle. httpkernel doesn't know about this method.

Copy link

Contributor

Tobion commentedDec 12, 2015

Thank you@voronkovich.

Tobion merged commit7528134 intosymfony:3.0

Dec 12, 2015

Tobion added a commit that referenced this pull request

Dec 12, 2015

bug#16970[HttpKernel] HttpCache: remove an ESI instance checking (v…

605e133

…oronkovich)This PR was merged into the 3.0 branch.Discussion----------[HttpKernel] HttpCache: remove an ESI instance checking| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | no| License       | MIT| Doc PR        | noThis checking was added by this commit32d964b, but now it's not neededCommits-------7528134 Removed ESI instance check