Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
CSS min-height and min-width should not be "auto"#16964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
javiereguiluz commentedDec 11, 2015
I can confirm the bug and that the solution provided by@aschempp solves the problem in all browsers. Thanks! |
Member
nicolas-grekas commentedDec 18, 2015
Thank you@aschempp. |
nicolas-grekas added a commit that referenced this pull requestDec 18, 2015
This PR was merged into the 2.8 branch.Discussion----------CSS min-height and min-width should not be "auto"| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Setting `min-width` and `min-height` to `auto` does not work in Safari and IE. The `auto` property has been removed from the standard meanwhile (seehttps://developer.mozilla.org/en-US/docs/Web/CSS/min-height).Correct is to set a minimum of zero, which is actually "no minimum height".This is what the web profiler looks like before and after on latest Safari:Commits-------107c44a CSS min-height and min-width should not be "auto"
ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull requestMar 25, 2018
…aschempp)This PR was merged into the 2.8 branch.Discussion----------CSS min-height and min-width should not be "auto"| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Setting `min-width` and `min-height` to `auto` does not work in Safari and IE. The `auto` property has been removed from the standard meanwhile (seehttps://developer.mozilla.org/en-US/docs/Web/CSS/min-height).Correct is to set a minimum of zero, which is actually "no minimum height".This is what the web profiler looks like before and after on latest Safari:Commits-------107c44a CSS min-height and min-width should not be "auto"
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
min-widthandmin-heighttoautodoes not work in Safari and IE. Theautoproperty has been removed from the standard meanwhile (seehttps://developer.mozilla.org/en-US/docs/Web/CSS/min-height).Correct is to set a minimum of zero, which is actually "no minimum height".
This is what the web profiler looks like before and after on latest Safari: