Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] Replace "weak-verbose" by "deprecations upper bound" mode#16937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this will break the regex filtering feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
indeed... fixed!
stof commentedDec 10, 2015
I suggest adding some phpdoc on the |
nicolas-grekas commentedDec 10, 2015
@stof good idea, done |
craue commentedDec 10, 2015
I actually like the weak-verbose mode. What's wrong with it? But as long as I just need to set a very high number to achieve the same, I'm fine with it. |
nicolas-grekas commentedDec 10, 2015
@craue that's how you can get the equivalent of weak-verbose yes |
wouterj commentedDec 10, 2015
👍 This is indeed a better solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the default valuefalse does not match the document types :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
default value set to0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Well, acceptingfalse should be kept, for easy usage withgetenv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ok :) updated
2037821 todfe59d9CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Isscalar supported by common IDEs or should we useint|string|bool instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you're right,scalar is not a keyword of phpdoc:http://phpdoc.org/docs/latest/references/phpdoc/types.html
…s upper bound" mode (nicolas-grekas)This PR was merged into the 2.8 branch.Discussion----------[PhpUnitBridge] Replace "weak-verbose" by "deprecations upper bound" mode| Q | A| ------------- | ---| Bug fix? | yes| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#16789,#14475| License | MIT| Doc PR | -This is a "new feature" that replaces a "new feature" not yet released but merged into 2.8.1. See#16789.It is way more flexible to be able to specify the upper bound of remaining deprecation notices that you allow in your test suite. This allows lowering this number while deprecations are removed, step after step.ping@wouterj@Tobion@craue@fabpot@stofCommits-------58cd3ee [PhpUnitBridge] Replace "weak-verbose" by "deprecations upper bound" mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Whatfalse does doesn't seem to be defined at all.
It's the first release with the deprecations upper bound feature included:symfony/symfony#16937
This is a "new feature" that replaces a "new feature" not yet released but merged into 2.8.1. See#16789.
It is way more flexible to be able to specify the upper bound of remaining deprecation notices that you allow in your test suite. This allows lowering this number while deprecations are removed, step after step.
ping@wouterj@Tobion@craue@fabpot@stof