Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] fixed definition loosing property shared when decorated by a parent definition#16926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ecorated by a parent definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IMO you should put thissetShared(false) in the definition of the parent service in order to test if we pass the same shared value to their childrens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@dosten the shared flag is always taken from the child (same than the scope in 2.x, as this is the replacement for the scope)
ivarb commentedDec 16, 2015
Also noticed this bug while upgrading from 2.7 to 2.8. Would very much appreciate this patch in 2.8 👍 |
nicolas-grekas commentedDec 18, 2015
👍 |
fabpot commentedDec 18, 2015
Thank you@wahler. |
…ared when decorated by a parent definition (wahler)This PR was squashed before being merged into the 2.8 branch (closes#16926).Discussion----------[DependencyInjection] fixed definition loosing property shared when decorated by a parent definition| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |While upgrading my applications from 2.7 and 2.8 I found out that the attribute "shared" gets lost when a parent is configured. I wrote a Test to confirm my assumption and added a bugfixCommits-------d3a4a77 [DependencyInjection] fixed definition loosing property shared when decorated by a parent definition
While upgrading my applications from 2.7 and 2.8 I found out that the attribute "shared" gets lost when a parent is configured. I wrote a Test to confirm my assumption and added a bugfix