Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] [Bug] Fixes new InputStyle bug #16920#16922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
AlmogBaku commentedDec 9, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #16920 |
| License | MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should probably be reverted, the helper need the Output instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This one should probably be left as$output->getVerbosity()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You are probably right. Using the original object will give better performance than the wrapped one.
DONE
Tobion commentedDec 9, 2015
Good catch, thanks@AlmogBaku. |
…lmogBaku)This PR was squashed before being merged into the 2.8 branch (closes#16922).Discussion----------[FrameworkBundle] [Bug] Fixes new InputStyle bug#16920| Q | A| ------------- | ---| Bug fix? | **yes**| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | **yes**| Fixed tickets |#16920| License | MITCommits-------d2b9a1d [FrameworkBundle] [Bug] Fixes new InputStyle bug#16920