Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Debug] simplify error_reporting levels given php version > 5.3#16916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I will add a deprecation for thenull case in 3.1 as it is useless now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This might become an issue in the future when new constants are introduced in future PHP versions (similar to the introduction of theE_STRICT constant).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The E_ALL is supposed to include everything which is why it was changed in 5.4
Tobion commentedDec 9, 2015
@nicolas-grekas this is for you to review :) |
nicolas-grekas commentedDec 9, 2015 via email
Ack, I should be able to do it tomorrow |
xabbuh commentedDec 9, 2015
What about defining the |
Tobion commentedDec 9, 2015
E_ALL has a different meaning in PHP 5.3 and >= 5.4. That is problem. So we cannot do anything in Polyfill. |
xabbuh commentedDec 9, 2015
@Tobion I see, but then treating |
nicolas-grekas commentedDec 10, 2015
Since PHP 7 introduced exceptions in the core, I seriously doubt that any new |
fabpot commentedDec 18, 2015
Thank you@Tobion. |
…n > 5.3 (Tobion)This PR was merged into the 3.0 branch.Discussion----------[Debug] simplify error_reporting levels given php version > 5.3| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Since PHP 5.4 `E_ALL` contains `E_STRICT`. This allows us to simplify and clean up some code.Commits-------b1c774f simplify debug error_reporting levels given php version > 5.3
GrahamCampbell commentedDec 18, 2015
I thought symfony always used |
Tobion commentedDec 18, 2015
Neither symfony nor php itself uses null by default when it doesn't make sense. E.g.http://php.net/manual/en/function.trigger-error.php |
GrahamCampbell commentedDec 18, 2015
PHP does in other cases, where the param might end up being an int though. |
GrahamCampbell commentedDec 18, 2015
Meh. I'm inclined to agree with you I guess. |
Since PHP 5.4
E_ALLcontainsE_STRICT. This allows us to simplify and clean up some code.