Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DX] [PropertyInfo] Filter PropertyInfo Extractors with Interfaces#16890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[DX] [PropertyInfo] Filter PropertyInfo Extractors with Interfaces#16890
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Use a single service tag to filter a central source of information extractor instances.Since PropertyInfo requires PHP 5.5+, use ::class constant to negate the use of class constants or strings.
dunglas commentedDec 7, 2015
It is not possible because it doesn't handle every use cases, see#15858 (comment) and my reply for details. |
zanbaldwin commentedDec 7, 2015
You're absolutely right, I didn't take into account different ordering for different types. |
dunglas commentedDec 7, 2015
But as you're the second person asking why after@fabpot, it can be a good idea to mention it in the doc :-) |
zanbaldwin commentedDec 7, 2015
I'll update the documentation PR to include the explanation in your comment, since it's an important but not immediately obvious decision. |
To improve developer experience, require just one collection of extractors that filters by the interfaces that have been implemented on each extractor.
However, thisdoes break backwards-compatibility for:
PropertyInfoExtractor.PropertyInfoExtractor.property_info.*_extractortags.I'm suggesting this change purely in the unlikely event that the PropertyInfo component can be classed as internal, since documentation is still pending.
/cc@dunglas