Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Ldap] Escape carriage returns in LDAP DNs.#16842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You should skip the test if the extension is not enabled, which is the case in one of the two Appveyor builds (one is run with the extension, the other without).
ChadSikorra commentedDec 10, 2015
I adjusted the test to require the LDAP extension. Seems to have appeased Appveyor anyway. |
csarrazi commentedDec 10, 2015
LGTM 👍 |
fabpot commentedDec 18, 2015
Thank you@ChadSikorra. |
This PR was squashed before being merged into the 2.8 branch (closes#16842).Discussion----------[Ldap] Escape carriage returns in LDAP DNs.Depends upon this commit in polyfill:symfony/polyfill#14| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aCarriage returns are supposed to be escaped in a LDAP DN. Leading and trailing spaces should be encoded as well. The spaces were taken care of in the polyfill implementation of `ldap_escape`, but the actual PHP function doesn't do the same. So I moved that logic within the component function and removed it from the polyfill function.Commits-------2243db4 [Ldap] Escape carriage returns in LDAP DNs.
Depends upon this commit in polyfill:symfony/polyfill#14
Carriage returns are supposed to be escaped in a LDAP DN. Leading and trailing spaces should be encoded as well. The spaces were taken care of in the polyfill implementation of
ldap_escape, but the actual PHP function doesn't do the same. So I moved that logic within the component function and removed it from the polyfill function.