Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix constraint validator alias being required#16841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Mx-Glitter
Copy link
Contributor

QA
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#16805
LicenseMIT
Doc PRsymfony/symfony-docs#5952

This is my first contribution, so everything might not be in perfect order.

fabpotand others added30 commitsSeptember 28, 2015 22:39
…urce() which was deprecated in 2.8 (mpdude)This PR was squashed before being merged into the 3.0-dev branch (closessymfony#15929).Discussion----------[3.0][Config] Remove ResourceInterface::getResource() which was deprecated in 2.8| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | no| BC breaks?    | yes| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Deprecated insymfony#15719.Commits-------7cef180 [3.0][Config] Remove ResourceInterface::getResource() which was deprecated in 2.8
Conflicts:composer.jsonsrc/Symfony/Bundle/FrameworkBundle/Command/RouterApacheDumperCommand.phpsrc/Symfony/Bundle/FrameworkBundle/Command/RouterDebugCommand.phpsrc/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.phpsrc/Symfony/Bundle/SecurityBundle/Resources/config/security.xmlsrc/Symfony/Bundle/SecurityBundle/Resources/config/security_listeners.xmlsrc/Symfony/Bundle/TwigBundle/Controller/ExceptionController.phpsrc/Symfony/Component/ClassLoader/ApcUniversalClassLoader.phpsrc/Symfony/Component/ClassLoader/DebugClassLoader.phpsrc/Symfony/Component/ClassLoader/UniversalClassLoader.phpsrc/Symfony/Component/Console/Input/StringInput.phpsrc/Symfony/Component/Debug/DebugClassLoader.phpsrc/Symfony/Component/DependencyInjection/Container.phpsrc/Symfony/Component/DependencyInjection/ContainerBuilder.phpsrc/Symfony/Component/DependencyInjection/ContainerInterface.phpsrc/Symfony/Component/DependencyInjection/Definition.phpsrc/Symfony/Component/DependencyInjection/DefinitionDecorator.phpsrc/Symfony/Component/DependencyInjection/Scope.phpsrc/Symfony/Component/DependencyInjection/ScopeInterface.phpsrc/Symfony/Component/DomCrawler/composer.jsonsrc/Symfony/Component/EventDispatcher/Event.phpsrc/Symfony/Component/HttpKernel/Kernel.phpsrc/Symfony/Component/HttpKernel/KernelInterface.phpsrc/Symfony/Component/HttpKernel/Log/LoggerInterface.phpsrc/Symfony/Component/HttpKernel/Log/NullLogger.phpsrc/Symfony/Component/Security/Core/composer.jsonsrc/Symfony/Component/Security/Resources/translations/security.tr.xlfsrc/Symfony/Component/Security/composer.jsonsrc/Symfony/Component/Translation/Translator.php
…(xabbuh)This PR was merged into the 3.0-dev branch.Discussion----------[Ldap] update branch alias for the master branch| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Commits-------b4092a7 [Ldap] update branch alias for the master branch
* 2.8:  Remove profiler storages  deprecate finding deep items in request parameters  [CssSelector] updated README  [CssSelector] remove ConverterInterface  [DependencyInjection] improved a comment for reading fluency  [HttpKernel] change a class in tests to avoid depending on SQLite  [FrameworkBundle] Fix tests  [Bridge\Twig] Fix form lowest version  [ci] Display fastest results first when running tests in parallel  [Yaml] Improve newline handling in folded scalar blocks
* 2.8:  fixed deprecation notices  fixed typos  [FrameworkBundle] Tag deprecated services  [VarDumper] Dump PHP+Twig code excerpts in backtraces  [Config] Fix ArrayNode extra keys "ignore" and "remove" behaviors
* 2.8:  add dependency required by a replaced package  Add a way to group toolbar info pieces  Added general sf-toolbar-block-right class  Bind input before executing the COMMAND event
…terJ)This PR was merged into the 3.0-dev branch.Discussion----------[3.0][Security] Remove deprecated features| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | no| BC breaks?    | yes| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Commits-------c3c5989 Remove more tests6f9e897 Remove AbstractVoter#isGranted() method6b6de15 Removed supports{Attribute,Class}() methods
* 2.8:  fix test for not configured form action attribute  do not render empty form action attributes  deprecated lifetime profiler option
* 2.8:  [Form] made the tests compatible with 3.0
…es (fabpot)This PR was merged into the 3.0-dev branch.Discussion----------[HttpKernel] removed deprecated profiler storages| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aCommits-------2925df5 [HttpKernel] removed deprecated profiler storages
…) deep argument (fabpot)This PR was merged into the 3.0-dev branch.Discussion----------[HttpFoundation] removed the ParameterBag::get() deep argument| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aCommits-------317f7b4 [HttpFoundation] removed the ParameterBag::get() deep argument
* 2.8:  [Security] made tests work for 2.8 and 3.0
* 2.8:  Use PHPUnit 5.0 for PHP 7  [DomCrawler] always pass base href to subcrawlers
* 2.8:  fixed typo
* 2.8:  Fix merge  Fix appveyor.yml missing ANSICON env var  [appveyor] merge test matrix in a single job  [travis] Skip testing intermediate PHP versions on pull requestsConflicts:.travis.ymlappveyor.yml
…res (WouterJ)This PR was squashed before being merged into the 3.0-dev branch (closessymfony#15904).Discussion----------[3.0][FrameworkBundle] Removed deprecated features| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | yes| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Commits-------fc41cf0 [3.0][FrameworkBundle] Removed deprecated features
…es (WouterJ)This PR was squashed before being merged into the 3.0-dev branch (closessymfony#15900).Discussion----------[3.0][DoctrineBridge] Removed deprecated features| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | yes| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Commits-------6dc3cf9 [3.0][DoctrineBridge] Removed deprecated features
voronkovichand others added7 commitsDecember 11, 2015 19:11
…king (voronkovich)This PR was merged into the 3.0 branch.Discussion----------[HttpKernel] HttpCache: remove an ESI instance checking| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | no| License       | MIT| Doc PR        | noThis checking was added by this commitsymfony@32d964b, but now it's not neededCommits-------7528134 Removed ESI instance check
…riggerDeprecation flag (ogizanagi)This PR was merged into the 3.0 branch.Discussion----------[FrameworkBundle][HttpKernel] Remove remaining $triggerDeprecation flag| Q             | A| ------------- | ---| Fixed tickets | n/a| License       | MITIntroduced insymfony#14665, this flag controlled the deprecation notice triggering when using the `ContainerAwareHttpKernel`, in order to avoid triggering it when using this class in the Symfony framework. This class no longer exists now, neither the flag.Commits-------ac15454 [FrameworkBundle][HttpKernel] Remove remaining $triggerDeprecation flag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

typo here: "ValidatoFactory"

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixed

@webmozart
Copy link
Contributor

Apart from the typo this looks good to me! 👍

Status: Reviewed

Hugo Hamonand others added3 commitsDecember 18, 2015 08:55
… of ChoiceType (nicolas-grekas)This PR was merged into the 3.1-dev branch.Discussion----------[Form] Deprecate the "choices_as_values" option of ChoiceType| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Commits-------9aa5507 [Form] Deprecate the "choices_as_values" option of ChoiceType
…ller::createForm() method. (hhamon)This PR was merged into the 3.0 branch.Discussion----------[FrameworkBundle] fixes outdated phpdoc on Controller::createForm() method.| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | ~| License       | MIT| Doc PR        | ~Commits-------3d0c4dd [FrameworkBundle] fixes outdated phpdoc on Controller::createForm() method.
@nicolas-grekas
Copy link
Member

If this is a bug fix, it should be merged on 2.3, if it's a new feature it's for master.
@Triiistan I'm not sure the renaming of variables provides any value, nor the $serviceDefinition tmp var. Use$container->getDefinition($id)->getClass() instead?

@Mx-Glitter
Copy link
ContributorAuthor

@nicolas-grekas The underlying issue isdocumented as an intended limitation, so I think it can be considered a new feature, and it is backwards compatible (if I'm not mistaken). Isn't 2.8 the right branch for it then, according to thecontribution documentation?

The renaming and temporary variable were to make the code consistent with theFormPass in the same folder. I don't see any problem reverting that if you prefer.

@Mx-GlitterMx-Glitterforce-pushed thefix-constraint-validator-alias-required branch fromee3a4b4 to43aeddfCompareDecember 18, 2015 10:22
@xabbuh
Copy link
Member

@Triiistan Thanks for pointing this out. The description you linked to is outdated and must be updated (seesymfony/symfony-docs#6045).

nicolas-grekasand others added6 commitsDecember 18, 2015 16:43
* 2.8:  prefer phpunit 5.x on hhvm  Reflected the change of the choice_value option in the Upgrade information  [FrameworkBundle][HttpKernel] the finder is required to discover bundle commands  [travis] Auto-conf deps=high matrix line  fix error level for deprecation  Fix the logout path when not using the router  Fix the logout path when not using the router  [Form] cast IDs to match deprecated behaviour of EntityChoiceList  [FrameworkBundle] minor: fix property_info service name in composer.json  [HttpFoundation] Added the ability of mapping stream wrapper protocols when using X-Sendfile  [HttpFoundation] Add a test case for using BinaryFileResponse with stream wrappers  CSS min-height and min-width should not be "auto"Conflicts:.travis.ymlUPGRADE-2.8.mdappveyor.ymlsrc/Symfony/Bundle/FrameworkBundle/composer.jsonsrc/Symfony/Component/HttpFoundation/ParameterBag.php
* 3.0:  prefer phpunit 5.x on hhvm  Reflected the change of the choice_value option in the Upgrade information  [FrameworkBundle][HttpKernel] the finder is required to discover bundle commands  [travis] Auto-conf deps=high matrix line  [FrameworkBundle] fixes outdated phpdoc on Controller::createForm() method.  fix error level for deprecation  Fix the logout path when not using the router  Fix the logout path when not using the router  [Form] cast IDs to match deprecated behaviour of EntityChoiceList  [FrameworkBundle] minor: fix property_info service name in composer.json  [HttpFoundation] Added the ability of mapping stream wrapper protocols when using X-Sendfile  [HttpFoundation] Add a test case for using BinaryFileResponse with stream wrappers  CSS min-height and min-width should not be "auto"
… version > 5.3 (Tobion)This PR was merged into the 3.0 branch.Discussion----------[Debug] simplify error_reporting levels given php version > 5.3| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Since PHP 5.4 `E_ALL` contains `E_STRICT`. This allows us to simplify and clean up some code.Commits-------b1c774f simplify debug error_reporting levels given php version > 5.3
* 2.8:  Fix merge  [Form] fix BC break introduced with prototype_data option  [Ldap] Escape carriage returns in LDAP DNs.  Upgrade for 2.8: ContainerAware was deprecated in favour of ContainerAwareTrait [ci skip]  Fix wrong method name mapping in UPGRADE-3.0.md  Use correct height for clearer  [Validator] fixed raising violations to a maximum of oneConflicts:UPGRADE-2.8.md
* 3.0:  Fix merge  [Form] fix BC break introduced with prototype_data option  [Ldap] Escape carriage returns in LDAP DNs.  Upgrade for 2.8: ContainerAware was deprecated in favour of ContainerAwareTrait [ci skip]  simplify debug error_reporting levels given php version > 5.3  Fix wrong method name mapping in UPGRADE-3.0.md  Use correct height for clearer  [Validator] fixed raising violations to a maximum of one
@Mx-Glitter
Copy link
ContributorAuthor

Closed in favor of#17074 on the right branch

fabpot added a commit that referenced this pull requestFeb 23, 2016
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17074).Discussion----------Fix constraint validator alias being required| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#16805| License       | MIT| Doc PR        |symfony/symfony-docs#6055This is my first contribution, so everything might not be in perfect order.Follow-up of#16841 on the right branch.Commits-------5136c30 Fix constraint validator alias being required
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

28 participants

@Mx-Glitter@webmozart@nicolas-grekas@xabbuh@gggeek@stof@Tobion@TomasVotruba@rvanlaak@SoboLAN@tackerm@carsonbot@fabpot@wouterj@Koc@pvandommelen@mpajunen@kbond@blanchonvincent@Seldaek@belka-ew@GrahamCampbell@rande@ogizanagi@havvg@GuilhemN@NothingWeAre@voronkovich

[8]ページ先頭

©2009-2025 Movatter.jp